-
-
Notifications
You must be signed in to change notification settings - Fork 216
Update SpongeForge to Minecraft 1.19.4 #3898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e1d5c8 to
3aa2b75
Compare
b7c5ed6 to
50d9324
Compare
Yeregorix
commented
Nov 4, 2023
| } | ||
|
|
||
| for (ForgeRegistry.Snapshot snapshot : cir.getReturnValue().values()) { | ||
| snapshot.ids.keySet().removeIf(loc -> loc.getNamespace().equals("sponge")); |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure filtering sponge data here is the correct solution. Also, this currently doesn't support any data registered by plugins.
0c774c8 to
2ee5c62
Compare
Signed-off-by: Chris Sanders <[email protected]>
This also fixes the ip issue.
2ee5c62 to
69d4887
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
ModLauncher has added 4 ModuleLayers. Each with specific roles.
We can choose which layer we want our classes to be loaded in, per jar by declaring the correct mod type in the mod manifest or the Java manifest.
Only the
GAMElayer is transformable.Notable changes
architectury-loomhas been updated from0.7.2-SNAPSHOTto1.1-SNAPSHOT(we are still using a fork)applaunchis now packaged in a separate jar becauseIModLocators must be loaded in theSERVICElayer.langhas been added and is packaged in a separate jar because language providers must be loaded in thePLUGINlayer.PluginContaineris now implemented via a wrapper instead of a mixin.GAMELIBRARYmod type instead ofLIBRARY. Eg: adventure.spongeandspongeapi. We now register proper mods so we can declare everything into a singlemods.toml. As required by FML.PluginModContainerno longer extendsFMLModContainer.@Listenerannotation. We add 3 instructions in<clinit>to obtain a privilegedMethodHandles.Lookup.TODO
No longer shade AW transformer in SF because we are now using ATs.This will be done later when updating ModLauncher in SpongeVanilla.