Fix library being incorrectly declared as a LIBRARY
#73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sychic
added a commit
to EssentialGG/Elementa
that referenced
this pull request
Jun 27, 2024
…necraft classes Related: EssentialGG/UniversalCraft#73
Sychic
changed the title
FMLModType to GAMELIBRARY to allow for access to minecraft classesLIBRARY
Sychic
changed the title
LIBRARYLIBRARY
This was referenced Jun 27, 2024
Johni0702
approved these changes
Jun 28, 2024
This was referenced Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70
This corrects the library being incorrectly labelled as a
LIBRARYand thus breaking usage with Sinytra Connector.LIBRARYdoes not have access to minecraft classes because it is in the plugin layer.GAMELIBRARYis in the game layer so it can access minecraft classes.Source: SpongePowered/Sponge#3898