Separated a11y and vis tests and made vis test be triggered by /vistest
#7402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+3
to
+7
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - next |
Contributor
Author
There was a problem hiding this comment.
A11y tests now run on all pushes to main and next... worth pointing out and sense checking
alex-page
approved these changes
Oct 17, 2022
Member
alex-page
left a comment
alex-page
left a comment
There was a problem hiding this comment.
Looks good to me. Pinging @samrose3 and @aaronccasanova who also worked on snapit in case they have any thoughts.
We will also need to let folks know in #polaris slack channel about this change.
Member
|
Also looks good to me. We should update the contributing or release documentation to let people know when it is appropriate to use |
sam-b-rose
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the vis tests cost money and we don't need them run on each merge to
main. We should eventually move off of storybook and run real visual regression testing but until then let's make the vis tests be triggered by a comment/vistestand go from there.TODO:
CONTRIBUTING.mdfile?