Separated a11y and vis tests and made vis test be triggered by /vistest (#7402)

Running the vis tests cost money and we don't need them run on each
merge to `main`. We should eventually move off of storybook and run real
visual regression testing but until then let's make the vis tests be
triggered by a comment `/vistest` and go from there.

TODO:
- [x] We need add documentation for this new comment. I assume into the
[`CONTRIBUTING.md`](https://github.com/Shopify/polaris/blob/00449becb15df24d22d7d062e2e20cda7c14d954/.github/CONTRIBUTING.md)
file?
- [ ] Test the workflow. I moved things and merged things in. in theory
this should work but I have not tested it yet

Author: dominikwilkowski

.github/CONTRIBUTING.md

@@ -155,6 +155,7 @@ We recommend running tests as well as trying your build of a package in a real p
 
 - `yarn test` will run tests for all packages
 - `yarn turbo run test --filter="[HEAD^1]"` will test any package that has changed in the last commit
+- Run visual testing via adding the `/vistest` comment in a PR
 
 You can test your changes in another project locally by creating a [snapshot release](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#snapshot-release).
 

.github/workflows/ci-a11y.yml

@@ -0,0 +1,46 @@
+name: Accessibility Tests
+
+on:
+  push:
+    branches:
+      - main
+      - next
+
+jobs:
+  accessibility_test:
+    name: 'Accessibility test'
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout branch
+        uses: actions/checkout@v3
+
+      - name: Setup Node with v16.13.0
+        uses: actions/setup-node@v3
+        with:
+          node-version: 16.13.0
+          cache: yarn
+
+      - name: Restore cache
+        uses: actions/cache@v3
+        with:
+          path: |
+            **/.turbo
+            node_modules/.cache/turbo
+            polaris-react/build-internal/cache
+          key: ${{ runner.os }}-accessibility-test-v1-${{ github.sha }}
+          restore-keys: |
+            ${{ runner.os }}-accessibility-test-v1-
+
+      - name: Install dependencies
+        run: yarn --frozen-lockfile
+
+      - name: Build packages
+        run: yarn turbo run build --filter=@shopify/polaris
+
+      - name: Build Storybook
+        run: yarn workspace @shopify/polaris run storybook:build --quiet
+
+      - name: Run accessibility test
+        run: node ./polaris-react/scripts/accessibility-check.js
+        env:
+          STORYBOOK_DISABLE_DOCS: 1

.github/workflows/ci-a11y-vrt.yml renamed to .github/workflows/vistest.yml

@@ -1,23 +1,15 @@
-name: Accessibility and Visual Regression Tests
+name: Visual Regression Tests
 
 on:
-  push:
-    branches:
-      - main
-      - next
-    paths:
-      - 'polaris-react/src/**'
-      - 'polaris-react/playground/**'
-      - 'polaris-tokens/src/**'
-  pull_request:
-    paths:
-      - 'polaris-react/src/**'
-      - 'polaris-react/playground/**'
-      - 'polaris-tokens/src/**'
+  issue_comment:
+    types:
+      - created
 
 jobs:
-  accessibility_test:
-    name: 'Accessibility test'
+  visual_regression_test:
+    name: 'Visual regression test'
+    if: |
+      github.event.issue.pull_request && github.event.comment.body == '/vistest'
     runs-on: ubuntu-latest
     steps:
       - name: Checkout branch
@@ -26,38 +18,36 @@ jobs:
       - name: Setup Node with v16.13.0
         uses: actions/setup-node@v3
         with:
-          node-version: 16.13.0
-          cache: yarn
+          permission: write
 
       - name: Restore cache
         uses: actions/cache@v3
         with:
-          path: |
-            **/.turbo
-            node_modules/.cache/turbo
-            polaris-react/build-internal/cache
-          key: ${{ runner.os }}-accessibility-test-v1-${{ github.sha }}
-          restore-keys: |
-            ${{ runner.os }}-accessibility-test-v1-
+          script: |
+            try {
+              const pullRequest = await github.rest.pulls.get({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                pull_number: context.issue.number,
+              })
 
-      - name: Install dependencies
-        run: yarn --frozen-lockfile
+              // Pull request from fork
+              if (context.payload.repository.full_name !== pullRequest.data.head.repo.full_name) {
+                const errorMessage = '`/vistest` is not supported on pull requests from forked repositories.'
 
-      - name: Build packages
-        run: yarn turbo run build --filter=@shopify/polaris
-
-      - name: Build Storybook
-        run: yarn workspace @shopify/polaris run storybook:build --quiet
+                await github.rest.issues.createComment({
+                  issue_number: context.issue.number,
+                  owner: context.repo.owner,
+                  repo: context.repo.repo,
+                  body: errorMessage,
+                })
 
-      - name: Run accessibility test
-        run: node ./polaris-react/scripts/accessibility-check.js
-        env:
-          STORYBOOK_DISABLE_DOCS: 1
+                core.setFailed(errorMessage)
+              }
+            } catch (err) {
+              core.setFailed(`Request failed with error ${err}`)
+            }
 
-  visual_regression_test:
-    name: 'Visual regression test'
-    runs-on: ubuntu-latest
-    steps:
       - name: Checkout branch
         uses: actions/checkout@v3
         with: