feat: CasADiDynamicOptProblem #3602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Test explicit method. | ||
| jprob = JuMPDynamicOptProblem(sys, u0map, tspan, parammap, dt = 0.01) | ||
| @test JuMP.num_constraints(jprob.model) == 2 # initials | ||
| jsol = solve(jprob, Ipopt.Optimizer, constructRK4, silent = true) |
There was a problem hiding this comment.
I thought this was changed to using the constructor? This would be natural as:
alg = JuMPCollocation(Ipopt.Optimizer, constructRK4())and
alg = CasADiCollocation("ipopt", constructRK4())There was a problem hiding this comment.
so the syntax is like sol = solve(jprob, JuMPCollocation(Ipopt.Optimizer, constructRK4())?
| silent = true) # 11.540 ms, 4.00 MiB | ||
| @test ≈(jsol2.sol.u, osol2.u, rtol = 0.001) | ||
| @test ≈(isol.sol.u, osol2.u, rtol = 0.001) | ||
| csol2 = solve(cprob, "ipopt", constructImplicitEuler, silent = true) |
There was a problem hiding this comment.
silent isn't a common kwarg. verbose.
ChrisRackauckas
approved these changes
May 9, 2025
|
I like it sans a few interface things, but let's merge so that the big PR is out of the way and do the little interface munging before it gets documented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires CasADi.jl 1.0.2