[INTERNAL] Resource#clone: Omit project association #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cloning a Resource, the new Resource instance should not be associated with any project. This allows for use cases where a resource is copied from one project to another. The problematic behavior was introduced with #448 and motivated by the need of the memory adapter to clone resources while keeping the project association. However, since memory adapters are always assigned a project, they can easily just assign that project to the cloned resource. This has been implemented in this PR.
RandomByte
force-pushed
the
resource-clone-remove-project-assoc
branch
from
957cdfb to
1ac5c24
Compare
flovogt
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cloning a Resource, the new Resource instance should not be associated with any project. This allows for use cases where a resource is copied from one project to another.
The problematic behavior was introduced with #448 and motivated by the need of the memory adapter to clone resources while keeping the project association.
However, since memory adapters are always assigned a project, they can easily just assign that project to the cloned resource. This has been implemented in this PR.