[BREAKING] Clone resources when writing in and reading from the Memory #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
Member
|
LGTM |
flovogt
commented
Dec 2, 2022
Member
Author
|
flovogt
changed the title
flovogt
force-pushed
the
memadapter-clone-resource-write
branch
from
add6c92 to
5c45184
Compare
…resource assigned to another project
…fer or createStream
…h of newly created resource
RandomByte
requested changes
Dec 14, 2022
RandomByte
approved these changes
Dec 14, 2022
RandomByte
added a commit
that referenced
this pull request
Dec 22, 2022
When cloning a Resource, the new Resource instance should not be associated with any project. This allows for use cases where a resource is copied from one project to another. The problematic behavior was introduced with #448 and motivated by the need of the memory adapter to clone resources while keeping the project association. However, since memory adapters are always assigned a project, they can easily just assign that project to the cloned resource. This has been implemented in this PR.
RandomByte
added a commit
that referenced
this pull request
Dec 22, 2022
When cloning a Resource, the new Resource instance should not be associated with any project. This allows for use cases where a resource is copied from one project to another. The problematic behavior was introduced with #448 and motivated by the need of the memory adapter to clone resources while keeping the project association. However, since memory adapters are always assigned a project, they can easily just assign that project to the cloned resource. This has been implemented in this PR.
RandomByte
added a commit
that referenced
this pull request
Dec 22, 2022
When cloning a Resource, the new Resource instance should not be associated with any project. This allows for use cases where a resource is copied from one project to another. The problematic behavior was introduced with #448 and motivated by the need of the memory adapter to clone resources while keeping the project association. However, since memory adapters are always assigned a project, they can easily just assign that project to the cloned resource. This has been implemented in this PR.
matz3
added a commit
that referenced
this pull request
Jan 4, 2023
Some tests didn't use the corresponding adapter, which caused race-conditions as both adapter tests used the FileSystem adapter. It is now ensured that all tests use the right adapter. Follow-up of #448
matz3
added a commit
that referenced
this pull request
Jan 9, 2023
Some tests didn't use the corresponding adapter, which caused race-conditions as both adapter tests used the FileSystem adapter. It is now ensured that all tests use the right adapter. Follow-up of #448
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
When cloning a Resource, the new Resource instance should not be associated with any project. This allows for use cases where a resource is copied from one project to another. The problematic behavior was introduced with SAP/ui5-fs#448 and motivated by the need of the memory adapter to clone resources while keeping the project association. However, since memory adapters are always assigned a project, they can easily just assign that project to the cloned resource. This has been implemented in this PR.
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
Some tests didn't use the corresponding adapter, which caused race-conditions as both adapter tests used the FileSystem adapter. It is now ensured that all tests use the right adapter. Follow-up of SAP/ui5-fs#448
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
When cloning a Resource, the new Resource instance should not be associated with any project. This allows for use cases where a resource is copied from one project to another. The problematic behavior was introduced with SAP/ui5-fs#448 and motivated by the need of the memory adapter to clone resources while keeping the project association. However, since memory adapters are always assigned a project, they can easily just assign that project to the cloned resource. This has been implemented in this PR.
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
Some tests didn't use the corresponding adapter, which caused race-conditions as both adapter tests used the FileSystem adapter. It is now ensured that all tests use the right adapter. Follow-up of SAP/ui5-fs#448
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
…emory (SAP/ui5-fs#448) BREAKING CHANGE: Resources stored in the adapters can not be modified by reference anymore. All modifications need to be persisted by using the #write method in order to be reflected in the adapter.
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
When cloning a Resource, the new Resource instance should not be associated with any project. This allows for use cases where a resource is copied from one project to another. The problematic behavior was introduced with SAP/ui5-fs#448 and motivated by the need of the memory adapter to clone resources while keeping the project association. However, since memory adapters are always assigned a project, they can easily just assign that project to the cloned resource. This has been implemented in this PR.
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
Some tests didn't use the corresponding adapter, which caused race-conditions as both adapter tests used the FileSystem adapter. It is now ensured that all tests use the right adapter. Follow-up of SAP/ui5-fs#448
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 26, 2025
…emory (SAP/ui5-fs#448) BREAKING CHANGE: Resources stored in the adapters can not be modified by reference anymore. All modifications need to be persisted by using the #write method in order to be reflected in the adapter.
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 26, 2025
When cloning a Resource, the new Resource instance should not be associated with any project. This allows for use cases where a resource is copied from one project to another. The problematic behavior was introduced with SAP/ui5-fs#448 and motivated by the need of the memory adapter to clone resources while keeping the project association. However, since memory adapters are always assigned a project, they can easily just assign that project to the cloned resource. This has been implemented in this PR.
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 26, 2025
Some tests didn't use the corresponding adapter, which caused race-conditions as both adapter tests used the FileSystem adapter. It is now ensured that all tests use the right adapter. Follow-up of SAP/ui5-fs#448
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 26, 2025
…emory (SAP/ui5-fs#448) BREAKING CHANGE: Resources stored in the adapters can not be modified by reference anymore. All modifications need to be persisted by using the #write method in order to be reflected in the adapter.
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 26, 2025
When cloning a Resource, the new Resource instance should not be associated with any project. This allows for use cases where a resource is copied from one project to another. The problematic behavior was introduced with SAP/ui5-fs#448 and motivated by the need of the memory adapter to clone resources while keeping the project association. However, since memory adapters are always assigned a project, they can easily just assign that project to the cloned resource. This has been implemented in this PR.
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 26, 2025
Some tests didn't use the corresponding adapter, which caused race-conditions as both adapter tests used the FileSystem adapter. It is now ensured that all tests use the right adapter. Follow-up of SAP/ui5-fs#448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone resources when writing them in the memory.
JIRA: CPOUI5FOUNDATION-567
Follow-Up of #259.