Skip to content

Revert the Go SDK back to v0.1, to use v1 transactions for Execute()! Disable auto-updating dependencies. #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 20, 2022

Conversation

NHDaly
Copy link
Member

@NHDaly NHDaly commented Jul 20, 2022

Prevent ./tidy script from updating dependencies

This was picking up even breaking changes from the rai-sdk-go, since
the -u flag indiscriminantly upgrades MINOR releases, so it would
change e.g. v0.1.0 to v0.2.0, even though that is a breaking change.

Set SDK to rai-sdk-go v0.1.1

NHDaly added 4 commits July 20, 2022 14:47
This was picking up even breaking changes from the rai-sdk-go, since
the `-u` flag indiscriminantly upgrades MINOR releases, so it would
change e.g. `v0.1.0` to `v0.2.0`, even though that is a breaking change.
@NHDaly NHDaly requested a review from vilterp July 20, 2022 21:11
@NHDaly NHDaly merged commit 7cad0dc into main Jul 20, 2022
@NHDaly NHDaly deleted the nhd-sdk-v0.1 branch July 20, 2022 21:15
@NHDaly
Copy link
Member Author

NHDaly commented Jul 20, 2022

CC: @bradlo: We disabled the -u part of the ./tidy script, since it was causing users to pick up breaking changes in the Go RAI SDK. Apparently -u doesn't respect leading zero v0 type version numbers. But we don't want to tag v1.0 since it's definitely not ready yet.

So for now, we've just removed the -u from the tidy script.
See also: golang/go#51922 (comment)

@NHDaly
Copy link
Member Author

NHDaly commented Jul 20, 2022

Note that this means someone needs to manually run go get -u ./rai/...; ./tidy on this repo every once in a while, and make sure the tests pass before merging.

Maybe we can set this up as a cron job, like we do for the julia projects?

From Pete: Maybe dependabot could work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants