Restore "pretty" printing after transactions v2 upgrade

[cpetitpas]

The "pretty" format output no longer works after work to upgrade to transactions v2. Further, the --format switch has no effect.
From #14:
After pull, ./tidy, ./make it seems that this has resulted in json formatted output regardless of the --format switch. Before the change:

chris@PetitpasServer:~$ raiOld exec cp-Tutorial -e cp0708_2 -c "def output = auntUncle"
Executing query (cp-Tutorial/cp0708_2) readonly=false .. Ok (1.0s)
# output (String*String)
"Chris", "Amanda"
"Chris", "David Jr"
"Chris", "Jaysin"
"Chris", "Nathan"
"Chris", "Steph"
"David", "Alex"
"David", "Amanda"
"David", "Chloe"
"David", "David Jr"
"David", "Jacob"
"David", "Jaysin"
"David", "Nathan"
"David", "Steph"
"Lisa", "Alex"
"Lisa", "Chloe"
"Lisa", "David Jr"
"Lisa", "Jacob"
"Lisa", "Jaysin"
"Lisa", "Nathan"
"Michael", "Alex"
"Michael", "Amanda"
"Michael", "Chloe"
"Michael", "Jacob"
"Michael", "Steph"

After the change:

chris@PetitpasServer:~$ rai exec cp-Tutorial -e cp0708_2 -c "def output = auntUncle"
Executing query (cp-Tutorial/cp0708_2) readonly=false .. Ok (2.9s)
{
  "Transaction": {
    "id": "d4b48bd8-cc02-f6f0-afaf-c30d47e67bd3",
    "state": "COMPLETED",
    "account_name": "relationalai-team-rd-language",
    "created_by": "GL2yojcCMPsD6RnWSKcX6HnnWQA3TRWl@clients",
    "created_on": 1657656632696,
    "database_name": "cp-Tutorial",
    "user_agent": "raictl/0.0.1",
    "query": "def output = auntUncle"
  },
  "Results": [
    {
      "RelationID": "v1",
      "Table": [
        "Chris",
        "Chris",
        "Chris",
        "Chris",
        "Chris",
        "David",
        "David",
        "David",
        "David",
        "David",
        "David",
        "David",
        "David",
        "Lisa",
        "Lisa",
        "Lisa",
        "Lisa",
        "Lisa",
        "Lisa",
        "Michael",
        "Michael",
        "Michael",
        "Michael",
        "Michael"
      ]
    },
    {
      "RelationID": "v2",
      "Table": [
        "Amanda",
        "David Jr",
        "Jaysin",
        "Nathan",
        "Steph",
        "Alex",
        "Amanda",
        "Chloe",
        "David Jr",
        "Jacob",
        "Jaysin",
        "Nathan",
        "Steph",
        "Alex",
        "Chloe",
        "David Jr",
        "Jacob",
        "Jaysin",
        "Nathan",
        "Alex",
        "Amanda",
        "Chloe",
        "Jacob",
        "Steph"
      ]
    }
  ],
  "Metadata": [
    {
      "relationId": "/:output/String/String",
      "types": [
        ":output",
        "String",
        "String"
      ]
    }
  ],
  "Problems": []
}

Testing shows that --format json or --format pretty no longer has any effect.
The pull/build:

chris@PetitpasServer:~/rai-cli$ git branch
* main
chris@PetitpasServer:~/rai-cli$ git pull
remote: Enumerating objects: 12, done.
remote: Counting objects: 100% (12/12), done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 9 (delta 4), reused 4 (delta 3), pack-reused 0
Unpacking objects: 100% (9/9), 1.35 KiB | 230.00 KiB/s, done.
From github.com:RelationalAI/rai-cli
   fd02a2e..de3073f  main             -> origin/main
 * [new branch]      pv-upgrade-to-v2 -> origin/pv-upgrade-to-v2
Updating fd02a2e..de3073f
Fast-forward
 .github/workflows/go.yml | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 .github/workflows/go.yml

chris@PetitpasServer:~/rai-cli$ ./tidy
go: downloading github.com/spf13/cobra v1.5.0
go: downloading github.com/relationalai/rai-sdk-go v0.0.0-20220706153214-e5f70e84e035
go: downloading github.com/apache/arrow v0.0.0-20220712194816-c6534a59a38a
go: downloading github.com/klauspost/compress v1.15.7
go: downloading github.com/pierrec/lz4/v4 v4.1.15
go: downloading golang.org/x/xerrors v0.0.0-20220609144429-65e65417b02f
go: downloading golang.org/x/tools v0.1.11
go: downloading github.com/goccy/go-json v0.9.8
go: downloading golang.org/x/sys v0.0.0-20220712014510-0a85c31ab51e
go: downloading golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4
go: upgraded github.com/goccy/go-json v0.9.7 => v0.9.8
go: upgraded github.com/klauspost/compress v1.15.6 => v1.15.7
go: upgraded github.com/pierrec/lz4/v4 v4.1.14 => v4.1.15
go: upgraded github.com/relationalai/rai-sdk-go v0.0.0-20220601014253-d82e4af6a549 => v0.0.0-20220706153214-e5f70e84e035
go: upgraded github.com/spf13/cobra v1.4.0 => v1.5.0
go: upgraded golang.org/x/mod v0.6.0-dev.0.20220106191415-9b9b3d81d5e3 => v0.6.0-dev.0.20220419223038-86c51ed26bb4
go: upgraded golang.org/x/sys v0.0.0-20220520151302-bc2c85ada10a => v0.0.0-20220712014510-0a85c31ab51e
go: upgraded golang.org/x/tools v0.1.10 => v0.1.11
go: upgraded golang.org/x/xerrors v0.0.0-20220517211312-f3a8303e98df => v0.0.0-20220609144429-65e65417b02f
chris@PetitpasServer:~/rai-cli$ ./make

[vilterp]

A note about what happened here:

My intention:

• only merge migrate to v2 transactions #16 (upgrade to v2) once pretty printing was fixed

What actually happened:

• we merged a commit of the Go SDK which made a breaking change: made Execute do v2 instead of v1
• when you ran ./tidy it upgraded the dependency in your checkout's go.mod to this version with v2, unintentionally upgrading your SDK and breaking pretty printing. Go's package manager's behavior here was unexpected to us: cmd/go: go get -u should not upgrade to unstable version golang/go#51922 (comment)

What we've done about it:

• @NHDaly's Revert the Go SDK back to v0.1, to use v1 transactions for Execute()! Disable auto-updating dependencies. #21 disables ./tidy from auto-upgrading deps, which should prevent this kind of unintended breakage in the future. It also pins the SDK to use V1, so pretty printing should work again if you pull, ./tidy, and ./make again.

What's up next:

• Keep working on migrate to v2 transactions #16; merging once V2 and pretty printing actually work

[cpetitpas]

Fix confirmed. After a reset (I had the previous changes locally), a pull and then running ./tidy and ./make the "pretty" output is restored and all seems to be working as expected.
Default:

chris@PetitpasServer:~$ rai exec cp-Tutorial -e cp-0720 -c "def output = auntUncle" --readonly
Executing query (cp-Tutorial/cp-0720) readonly=true .. Ok (34.6s)
# output (String*String)
"Chris", "Amanda"
"Chris", "David Jr"
"Chris", "Jaysin"
"Chris", "Nathan"
"Chris", "Steph"
"David", "Alex"
"David", "Amanda"
"David", "Chloe"
"David", "David Jr"
"David", "Jacob"
"David", "Jaysin"
"David", "Nathan"
"David", "Steph"
"Lisa", "Alex"
"Lisa", "Chloe"
"Lisa", "David Jr"
"Lisa", "Jacob"
"Lisa", "Jaysin"
"Lisa", "Nathan"
"Michael", "Alex"
"Michael", "Amanda"
"Michael", "Chloe"
"Michael", "Jacob"
"Michael", "Steph"

--format pretty:

chris@PetitpasServer:~$ rai exec cp-Tutorial -e cp-0720 -c "def output = auntUncle" --readonly --format pretty
Executing query (cp-Tutorial/cp-0720) readonly=true .. Ok (1.1s)
# output (String*String)
"Chris", "Amanda"
"Chris", "David Jr"
"Chris", "Jaysin"
"Chris", "Nathan"
"Chris", "Steph"
"David", "Alex"
"David", "Amanda"
"David", "Chloe"
"David", "David Jr"
"David", "Jacob"
"David", "Jaysin"
"David", "Nathan"
"David", "Steph"
"Lisa", "Alex"
"Lisa", "Chloe"
"Lisa", "David Jr"
"Lisa", "Jacob"
"Lisa", "Jaysin"
"Lisa", "Nathan"
"Michael", "Alex"
"Michael", "Amanda"
"Michael", "Chloe"
"Michael", "Jacob"
"Michael", "Steph"

--format json:

chris@PetitpasServer:~$ rai exec cp-Tutorial -e cp-0720 -c "def output = auntUncle" --readonly --format json
Executing query (cp-Tutorial/cp-0720) readonly=true .. Ok (1.1s)
{
  "aborted": false,
  "output": [
    {
      "rel_key": {
        "name": "output",
        "keys": [
          "String",
          "String"
        ],
        "values": []
      },
      "columns": [
        [
          "Chris",
          "Chris",
          "Chris",
          "Chris",
          "Chris",
          "David",
          "David",
          "David",
          "David",
          "David",
          "David",
          "David",
          "David",
          "Lisa",
          "Lisa",
          "Lisa",
          "Lisa",
          "Lisa",
          "Lisa",
          "Michael",
          "Michael",
          "Michael",
          "Michael",
          "Michael"
        ],
        [
          "Amanda",
          "David Jr",
          "Jaysin",
          "Nathan",
          "Steph",
          "Alex",
          "Amanda",
          "Chloe",
          "David Jr",
          "Jacob",
          "Jaysin",
          "Nathan",
          "Steph",
          "Alex",
          "Chloe",
          "David Jr",
          "Jacob",
          "Jaysin",
          "Nathan",
          "Alex",
          "Amanda",
          "Chloe",
          "Jacob",
          "Steph"
        ]
      ]
    }
  ],
  "problems": []
}
chris@PetitpasServer:~$

Thanks @vilterp .

[vilterp]

Thanks for confirming Chris! 🙏

[billscheidel-rai]

Note: This issue has been migrated to https://relationalai.atlassian.net/browse/RAI-6049.

This link is only accessible to employees of RelationalAI.