Skip to content

Conversation

mysterywolf
Copy link
Member

@mysterywolf mysterywolf commented Mar 3, 2022

拉取/合并请求描述:(PR description)

[
优化ULOG_OUTPUT_FLOAT,避免使用内置libc的vsnprintf函数
]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • 本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@armink
Copy link
Member

armink commented Mar 4, 2022

撤销ULOG_OUTPUT_FLOAT宏,该宏主要是启用vsprintf函数,该函数存在巨大的安全隐患,如果用户想用浮点型rt_kprintf,可以使用rt_kprintf完整版软件包

有没有完整版的 vsnprintf ?这个配置建议还是要保留的,挺多用户会遇到日志不能显示浮点问题,但不一定想的到是 vsnprintf 的问题

修复在开启RTC时戳情况下,ulog显示出现问题的情况 https://club.rt-thread.org/ask/question/434822.html

没看明白这个帖子里说明的 ulog 的啥 bug? libc 那边打印 "Cannot find a RTC device!" 过多吗?

@mysterywolf mysterywolf marked this pull request as draft March 4, 2022 02:00
@mysterywolf mysterywolf marked this pull request as ready for review March 4, 2022 04:09
@mysterywolf mysterywolf changed the title 移除ULOG_OUTPUT_FLOAT improve ULOG_OUTPUT_FLOAT, which avoids using inherent vsnprintf Mar 4, 2022
@mysterywolf mysterywolf requested a review from armink March 4, 2022 04:12
@Guozhanxin Guozhanxin added the +2 Agree +2 label Mar 4, 2022
@BernardXiong BernardXiong merged commit 86a1071 into RT-Thread:master Mar 6, 2022
@mysterywolf mysterywolf deleted the ulog2 branch March 6, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+2 Agree +2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants