Skip to content

Fix date filter in data viewer #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renkun-ken merged 1 commit into from
Jul 30, 2021
Merged

Fix date filter in data viewer #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 50 additions & 27 deletions src/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,45 @@ export async function getTableHtml(webview: Webview, file: string): Promise<stri
<link href="${String(webview.asWebviewUri(Uri.file(path.join(resDir, 'ag-theme-balham.min.css'))))}" rel="stylesheet">
<link href="${String(webview.asWebviewUri(Uri.file(path.join(resDir, 'ag-theme-balham-dark.min.css'))))}" rel="stylesheet">
<script>
const dateFilterParams = {
browserDatePicker: true,
comparator: function (filterLocalDateAtMidnight, cellValue) {
var dateAsString = cellValue;
if (dateAsString == null) return -1;
var dateParts = dateAsString.split('-');
var cellDate = new Date(Number(dateParts[0]), Number(dateParts[1]) - 1, Number(dateParts[2].substr(0, 2)));
if (filterLocalDateAtMidnight.getTime() == cellDate.getTime()) {
return 0;
}
if (cellDate < filterLocalDateAtMidnight) {
return -1;
}
if (cellDate > filterLocalDateAtMidnight) {
return 1;
}
}
};
const data = ${String(content)};
const gridOptions = {
defaultColDef: {
sortable: true,
resizable: true,
filter: true,
filterParams: {
buttons: ['reset', 'apply']
}
},
columnDefs: data.columns,
rowData: data.data,
rowSelection: 'multiple',
pagination: true,
enableCellTextSelection: true,
ensureDomOrder: true,
onGridReady: function (params) {
gridOptions.api.sizeColumnsToFit();
autoSizeAll(false);
}
};
function updateTheme() {
const gridDiv = document.querySelector('#myGrid');
if (document.body.classList.contains('vscode-light')) {
Expand All @@ -460,35 +498,20 @@ export async function getTableHtml(webview: Webview, file: string): Promise<stri
}
}
function autoSizeAll(skipHeader) {
var allColumnIds = [];
gridOptions.columnApi.getAllColumns().forEach(function (column) {
allColumnIds.push(column.colId);
});
gridOptions.columnApi.autoSizeColumns(allColumnIds, skipHeader);
var allColumnIds = [];
gridOptions.columnApi.getAllColumns().forEach(function (column) {
allColumnIds.push(column.colId);
});
gridOptions.columnApi.autoSizeColumns(allColumnIds, skipHeader);
}
const gridOptions = {
defaultColDef: {
sortable: true,
resizable: true,
filter: true,
filterParams: {
buttons: ['reset', 'apply']
}
},
columnDefs: data.columns,
rowData: data.data,
rowSelection: 'multiple',
pagination: true,
enableCellTextSelection: true,
ensureDomOrder: true,
onGridReady: function (params) {
gridOptions.api.sizeColumnsToFit();
autoSizeAll(false);
}
};
document.addEventListener('DOMContentLoaded', () => {
const gridDiv = document.querySelector('#myGrid');
new agGrid.Grid(gridDiv, gridOptions);
gridOptions.columnDefs.forEach(function(column) {
if (column.type === 'dateColumn') {
column.filterParams = dateFilterParams;
}
});
const gridDiv = document.querySelector('#myGrid');
new agGrid.Grid(gridDiv, gridOptions);
});
function onload() {
updateTheme();
Expand Down