Fix date filter in data viewer #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Filtering dates works nicely now, thanks! POSIX dates don't seem to be caught in |
Member
Author
|
POSIX dates will be coerced to strings, so they will be treated as text. |
ElianHugh
pushed a commit
to ElianHugh/vscode-R
that referenced
this pull request
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Closes #714
This PR defines a customized comparator that handles the
yyyy-MM-ddformat from R's Date format string and use this filter params for date columns on DOM loaded.(If you do not have screenshot) How can I check this pull request?
Run the following R code
Specify a date and condition in the filter window and it should work correctly now.