Fix false-positive E211 with match and case #989
Conversation
pycodestyle.py
Outdated
| # Allow "return (a.foo for a in range(5))" | ||
| not keyword.iskeyword(prev_text) and | ||
| # 'match' and 'case' are only soft keywords | ||
| prev_text not in ('match', 'case') |
There was a problem hiding this comment.
perhaps sys.version_info >= (3, 9) and not keyword.issoftkeyword(prev_text) (err, might need some boolean flipping, but you get the idea)
https://docs.python.org/3.10/library/keyword.html#keyword.issoftkeyword
testsuite/python310.py
Outdated
| #: Okay | ||
| case (1, 2): | ||
| pass | ||
| #: Okay |
There was a problem hiding this comment.
the #: is supposed to split separate cases -- you shouldn't need anything except the first comment (also please include the var1, var2 in the example)
There was a problem hiding this comment.
👌🏻 Didn't know that. Is there a way to run the test case only for Python 3.10+? Especially with the first change you suggested, the tests will fail without it.
There was a problem hiding this comment.
the file naming is supposed to handle that, but it looks like this needs to have a + added to the second digit group here:
pycodestyle/testsuite/support.py
Line 172 in c4460cb
|
Should I add 3.10 to Github CI action as well? |
yeah that would be good! thanks |
Done. All tests passed 🚀 |
|
Hi there! @asottile Do you plan to make a release with bug fixes for pattern matching support (this one in particular) before Python 3.10 comes out? |
|
please don't ask for releases, they will happen when they happen these are not bugfixes, this is a feature and it is not complete (there are still issues with |
3 participants
Fix false-positive
E211 whitespace before '('formatchandcase, Python 3.10