Fix false-positive with star pattern #1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
approved these changes
Jul 9, 2021
Member
asottile
left a comment
asottile
left a comment
There was a problem hiding this comment.
whew, thanks for improving that condition as well -- it was really difficult to understand before this patch
Member
Author
|
Just noticed that the PR hasn't been merged yet. Do you need me to add anything else? |
Member
Author
|
Any update now that |
Member
|
we have a dual sign off process for merging PRs, but whatever ask for forgiveness rather than permission |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #989: add ignore for soft keywords.
Closes #1002