External links gallery: add support for an arbitrary number of authors #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… assignment error
andersy005
requested review from
brian-rose,
clyne,
jukent,
kmpaul and
ktyle
as code owners
|
This is needed for #92, so I'm going to merge now. |
jukent
approved these changes
Jun 14, 2021
|
Great job @andersy005 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for an arbitrary number of authors. Previously, the gallery generator supported no more than 2 authors. This assumptions resulted in
UnboundLocalError: local variable 'authors_str' referenced before assignment errorerror. See https://readthedocs.org/projects/projectpythia/builds/13991093/. This fixes the build for #92.