Skip to content

Update external links gallery #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 15, 2021
Merged

Update external links gallery #107

merged 3 commits into from
Jun 15, 2021

Conversation

github-actions[bot]
Copy link
Contributor

Update external links gallery as requested in #106. Closes #106.

@github-actions github-actions bot mentioned this pull request Jun 14, 2021
Closed
@brian-rose
Copy link
Member

I don't know if it has anything to do with this PR, but it seems that the filters on the Links gallery are currently broken.

clyne
clyne previously approved these changes Jun 14, 2021
View reviewed changes
@clyne
Copy link
Contributor

clyne commented Jun 14, 2021

I don't know if it has anything to do with this PR, but it seems that the filters on the Links gallery are currently broken.

I noticed that as well and opened an issue #108

@andersy005
Copy link
Member

I don't know if it has anything to do with this PR, but it seems that the filters on the Links gallery are currently broken.

I don't think it's this PR. Filters appear to be broken on the main site, too. And it turns out that I may have broken it in #99 :). I am going to look into it shortly

@jukent
Copy link
Contributor

jukent commented Jun 14, 2021

I don't know if it has anything to do with this PR, but it seems that the filters on the Links gallery are currently broken.

I don't think it's this PR. Filters appear to be broken on the main site, too. And it turns out that I may have broken it in #99 :). I am going to look into it shortly

Oh no! Not sure where they would have broken though.

jukent
jukent reviewed Jun 14, 2021
View reviewed changes
@andersy005 andersy005 mentioned this pull request Jun 14, 2021
Merged
@andersy005
Copy link
Member

I don't know if it has anything to do with this PR, but it seems that the filters on the Links gallery are currently broken.

I don't think it's this PR. Filters appear to be broken on the main site, too. And it turns out that I may have broken it in #99 :). I am going to look into it shortly

I have a fix for this in #109

jukent
jukent previously approved these changes Jun 14, 2021
View reviewed changes
brian-rose
brian-rose reviewed Jun 15, 2021
View reviewed changes
@jukent jukent dismissed stale reviews from clyne and themself via b8df156 June 15, 2021 14:01
@jukent jukent mentioned this pull request Jun 15, 2021
Merged
@jukent jukent merged commit 92ae27b into main Jun 15, 2021
@andersy005 andersy005 deleted the external-links-gallery-106 branch June 15, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-rose brian-rose brian-rose approved these changes

@jukent jukent jukent approved these changes

@clyne clyne clyne left review comments

@kmpaul kmpaul Awaiting requested review from kmpaul

@ktyle ktyle Awaiting requested review from ktyle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Pangeo Gallery to the external links gallery
4 participants
@brian-rose @clyne @andersy005 @jukent