Add Adobeair #801
Merged
Add Adobeair #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 10, 2019 21:29
plata
requested changes
Jan 12, 2019
| if (version == null) { | ||
| regeditFileContent = | ||
| "REGEDIT4\n" + | ||
| "\n" + |
Collaborator
There was a problem hiding this comment.
This part is the same, so you could actually change the code to:
regeditFileContent =
"REGEDIT4\n" +
"\n" +
"[-HKEY_CURRENT_USER\\Software\\Wine]";
if (version) {
...
Member
Author
There was a problem hiding this comment.
No it is not if you look well
Collaborator
There was a problem hiding this comment.
Ah the "-" in front of HKEY is different. Didn't see that.
Still would prefer
if (version)over
if (version == null)
Member
Author
There was a problem hiding this comment.
Not sure because if version is undefined, then, we switch back to the getter. The I think in this particular case, we really need version to be explicitely null
Collaborator
There was a problem hiding this comment.
I see. It's not so nice from an API perspective.
plata
approved these changes
Jan 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #790