Verbs/Adobeair : Initial commit #790

Kreyren · 2019-01-05T11:14:37Z

Initial commit

Required for League Of Legends's Launcher

TODO: make sure that packaging does not break https://www.adobe.com/legal/terms.html 6.2

Warning: c04068e and 0d1aba2 are not to be trusted, commited based on my experince with adobeair, winetricks and what i remember from javascript + i'm not familiar with functions of phoenicis -> Hoped to provide a foundation to make commit easier to finish.

Initial commit Required for League Of Legends's Launcher

Engines/Wine/Verbs/adobeair/script.js

Needs verification, my skill in javascript is not to be trusted.. did my best tho >.>

Engines/Wine/Verbs/adobeair/script.js

Engines/Wine/Verbs/adobeair/script.json

Set free=true on demand, recommends verifying in terms of use. i'm not responsible if the information is wrong.

qparis · 2019-01-06T22:33:58Z

@Kreyren Can you also fix the codacy issues? https://app.codacy.com/app/PhoenicisOrg/scripts/pullRequest?prid=2827488

Kreyren · 2019-01-06T22:34:52Z

@qparis checking, not qualified to make the changes:

Based on https://app.codacy.com/app/PhoenicisOrg/scripts/pullRequest?prid=2827488

Line 17: should be present, it separates function from message.
Line 18: Taken from tahoma verb, seems relevant since adobeair is installed via terminal afaik.
...
Not sure what am i doing.

Zemogiter · 2019-01-07T10:34:40Z

Please fix indentation.

qparis · 2019-01-07T19:32:24Z

Yes, you have to fix the identation

Kreyren · 2019-01-07T22:40:08Z

Was AFK, investigating

Needs verification, not comfortable about what am i doing. Is line 14 sane for checksum? Using SHA-256 // Willing to fix if not Abadoning commit, not qualified to make changes in javascript for phoenicis atm.

Kreyren · 2019-01-07T23:08:14Z

Abadoning commit, not qualified to make changes in javascript for phoenicis atm.

qparis · 2019-01-07T23:31:26Z

The last commit looks good to me.

Commited on demand PhoenicisOrg#790 (comment)

qparis · 2019-01-08T13:15:57Z

@plata Can we merge?

plata · 2019-01-08T17:25:38Z

Engines/Wine/Verbs/adobeair/script.js

@@ -0,0 +1,35 @@
+include(["engines", "wine", "engine", "object"]);
+include(["utils", "functions", "net", "resource"]);
+include(["utils", "functions", "filesystem", "files"]);


Several of the includes seem to be unused. Please remove unnecessary.

@plata Can you make the commit? I'm not familiar with the functions -> Not qualified to decide what is needed and what is not.

or share lines that needs to be removed

From what I see, you do not need

include(["utils", "functions", "filesystem", "files"]); include(["engines", "wine", "verbs", "luna"]);

You should test that though.

@plata I'm unable to test it seems sane to remove tho..

Fixes: PhoenicisOrg#777 Depends on: PhoenicisOrg#790 Added new sources for installers from riot games BUG: Latin America South installer is missing Updated SHA-1 for EUW, LAN, OCE, JP, TR, BR, EUNE, NA, RU pick 61ce52e Update script.js pick 6fdf980 Update script.js pick 41cec24 Pushed League Of Legends in testing pick 6c05668 Update script.json pick 6ee39fc Script optimization pick 023059b Update script.js pick ff0facc Update script.js pick eb72429 Update script.js pick f731ecb Update script.js pick 5dd5058 Update script.js pick 645418f Update script.js pick 451850e Update script.js Signed-off-by: Jacob Hrbek <[email protected]>

qparis · 2019-01-09T21:59:30Z

Should be good now

Fixes: PhoenicisOrg#777 Fixes: PhoenicisOrg#778 Depends on: PhoenicisOrg#790 Added new sources for installers from riot games BUG: Latin America South installer is missing Updated SHA-1 for EUW, LAN, OCE, JP, TR, BR, EUNE, NA, RU Set MACOSX in testing since it's not tested. TODO : Performance can be improved beyond native, needs research Expected the game to run on platinum. pick 61ce52e Update script.js pick 6fdf980 Update script.js pick 41cec24 Pushed League Of Legends in testing pick 6c05668 Update script.json pick 6ee39fc Script optimization pick 023059b Update script.js pick ff0facc Update script.js pick eb72429 Update script.js pick f731ecb Update script.js pick 5dd5058 Update script.js pick 645418f Update script.js pick 451850e Update script.js Signed-off-by: Jacob Hrbek <[email protected]>

Causes error wile installing TODO: invesigate

Kreyren · 2019-01-10T06:49:29Z

Has issue:

Need info

plata

I don't think you want the League of Legends changes here, do you?

Kreyren · 2019-01-10T18:15:21Z

@plata removed the change notice 8b3b2db

plata · 2019-01-10T18:40:24Z

Please fix PR title, Travis and Codacy.

Create script.js

506c27d

Initial commit Required for League Of Legends's Launcher

plata requested changes Jan 5, 2019

View reviewed changes

Engines/Wine/Verbs/adobeair/script.js Show resolved Hide resolved

Kreyren added 2 commits January 5, 2019 11:19

Create script.json

c04068e

Update script.js

0d1aba2

Needs verification, my skill in javascript is not to be trusted.. did my best tho >.>

qparis reviewed Jan 5, 2019

View reviewed changes

Engines/Wine/Verbs/adobeair/script.js Outdated Show resolved Hide resolved

qparis reviewed Jan 5, 2019

View reviewed changes

Engines/Wine/Verbs/adobeair/script.js Show resolved Hide resolved

Kreyren mentioned this pull request Jan 5, 2019

Update League Of Legends script #778

Closed

madoar reviewed Jan 5, 2019

View reviewed changes

Engines/Wine/Verbs/adobeair/script.json Outdated Show resolved Hide resolved

Update script.json

af90630

Set free=true on demand, recommends verifying in terms of use. i'm not responsible if the information is wrong.

Update script.js

9621064

Needs verification, not comfortable about what am i doing. Is line 14 sane for checksum? Using SHA-256 // Willing to fix if not Abadoning commit, not qualified to make changes in javascript for phoenicis atm.

qparis approved these changes Jan 7, 2019

View reviewed changes

Update script.js

2ad56a8

Commited on demand PhoenicisOrg#790 (comment)

plata requested changes Jan 8, 2019

View reviewed changes

Update script.js

20581c9

Kreyren mentioned this pull request Jan 10, 2019

Update League Of Legends #797

Closed

Kreyren changed the title ~~Add adobeair in verbs~~ Verbs/Adobeair : Initial commit Jan 10, 2019

Jacob Hrbek added 2 commits January 10, 2019 06:27

Games/League of Legends : Removes GLSL

0e02a00

Causes error wile installing TODO: invesigate

oops

8b3b2db

plata requested changes Jan 10, 2019

View reviewed changes

qparis added 2 commits January 10, 2019 21:19

Update script.json

2852568

Delete script.json

e71b602

qparis mentioned this pull request Jan 10, 2019

Add Adobeair #801

Merged

qparis closed this Jan 10, 2019

Verbs/Adobeair : Initial commit #790

Verbs/Adobeair : Initial commit #790

Uh oh!

Conversation

Kreyren commented Jan 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qparis commented Jan 6, 2019

Uh oh!

Kreyren commented Jan 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zemogiter commented Jan 7, 2019

Uh oh!

qparis commented Jan 7, 2019

Uh oh!

Kreyren commented Jan 7, 2019

Uh oh!

Kreyren commented Jan 7, 2019

Uh oh!

qparis commented Jan 7, 2019

Uh oh!

qparis commented Jan 8, 2019

Uh oh!

plata Jan 8, 2019

Choose a reason for hiding this comment

Uh oh!

Kreyren Jan 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

plata Jan 9, 2019

Choose a reason for hiding this comment

Uh oh!

Kreyren Jan 10, 2019

Choose a reason for hiding this comment

Uh oh!

qparis commented Jan 9, 2019

Uh oh!

Kreyren commented Jan 10, 2019

Uh oh!

plata left a comment

Choose a reason for hiding this comment

Uh oh!

Kreyren commented Jan 10, 2019

Uh oh!

plata commented Jan 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Kreyren commented Jan 5, 2019 •

edited

Loading

Kreyren commented Jan 6, 2019 •

edited

Loading

Kreyren Jan 9, 2019 •

edited

Loading