Test against PHP 7.2 #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

carusogabriel wants to merge 1 commit into PHPOffice:develop from carusogabriel:patch-1

Contributor

carusogabriel commented Dec 1, 2017

Description

With the release of PHP 7.2, would be interesting to test it.

Checklist:

I have commented my code, particularly in hard-to-understand areas
I have run phpunit, phpcs, php-cs-fixer, phpmd
The new code is covered by unit tests
I have update the documentation to describe the changes


          Test against PHP 7.2

83c49fe

Contributor

troosan commented Dec 4, 2017

I added the PHP 7.2 build to #1185, which fixes a blocking error in PHP 7.2, which will have to correct anyway if we want to be 7.2 compatible.

troosan closed this

carusogabriel deleted the patch-1 branch

December 4, 2017 08:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet