rename 'Object' classes to 'OLEObject' (php 7.2 compatibility) #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pad any empty dropdown entries we find so that xmlWriter doesn't generate an error.
|
Scrutinizer said "Failed", but I can't see what's the problem? |
SailorMax
force-pushed
the
php72_support_object_classes
branch
from
6a7a180 to
2a84625
Compare
fix PHPCS errors add documentation add sample
add PHP 7.2 build
|
@SailorMax not a big fan of the name ObjectElement, it is too different from all other elements. |
|
I think you better know. |
into develop Conflicts: src/PhpWord/Shared/Html.php
…ixEmptyDropdownEntry Pad Empty Dropdown Entry
…ordProtection enable password protection (Word)
* Adding setParagraphStyle to Textrun for indentation * Html Image support added * fix formatting, add tests & update changelog
Merge develop branch to master branch
* add assertions in test methods without assertions * loosen dependencies so 7.0 & 7.1 builds can succeed * fix some scrutinizer errors * update release date
https://github.com/SailorMax/PHPWord into rename_object Conflicts: .travis.yml
|
still need tecnickcom/TCPDF#74 to be fully PHP 7.2 compatible |
troosan
changed the title
|
// Ignore me, just realised the error wasn't in your code, but ours! It was in an include line. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If name is not very good, now easier to find all require places to rename ;)