Skip to content

Clean elses #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2017
Merged

Clean elses #1222

merged 1 commit into from
Dec 19, 2017

Conversation

carusogabriel
Copy link
Contributor

  • I have commented my code, particularly in hard-to-understand areas
  • I have run phpunit, phpcs, php-cs-fixer, phpmd
  • The new code is covered by unit tests
  • I have update the documentation to describe the changes

I've removed the elses when we have already returned something 🚮

@troosan troosan merged commit 0f200d9 into PHPOffice:develop Dec 19, 2017
@troosan
Copy link
Contributor

troosan commented Dec 19, 2017

thanks for this!

@carusogabriel carusogabriel deleted the clean-elses branch December 19, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carusogabriel @troosan