Add split button to 'create dialog' #663
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,6 +35,10 @@ import { MatIconModule } from "@angular/material/icon"; | |
| import { MatListModule } from "@angular/material/list"; | ||
| import { MatProgressBarModule } from "@angular/material/progress-bar"; | ||
| import { MatInputModule } from "@angular/material/input"; | ||
| import { MatMenu, MatMenuModule } from "@angular/material/menu"; | ||
| import { MatTooltipModule } from "@angular/material/tooltip"; | ||
|
|
||
| type Action = 'ADD_CREATE' | 'ADD_ONLY'; | ||
|
|
||
| @Component({ | ||
| selector: "app-create-dialog", | ||
|
|
@@ -54,7 +58,9 @@ import { MatInputModule } from "@angular/material/input"; | |
| MatIconModule, | ||
| MatListModule, | ||
| MatProgressBarModule, | ||
| MatInputModule, | ||
| MatMenuModule, | ||
| MatTooltipModule | ||
| ], | ||
| providers: [], | ||
| }) | ||
|
|
@@ -76,6 +82,8 @@ export class CreateDialogComponent implements OnInit { | |
| this.amount() > 0 && | ||
| this.operationNumberFormControl.valid | ||
| ); | ||
| primaryAction = signal<Action>('ADD_CREATE'); | ||
|
|
||
|
|
||
| TranslationConstants = TranslationConstants; | ||
| //Form Controls | ||
|
|
@@ -144,7 +152,7 @@ export class CreateDialogComponent implements OnInit { | |
| } | ||
|
|
||
| detailsInputchanged(event: Event | KeyboardEvent) { | ||
| if (this.operations().length > 0) { | ||
| this.addValidationToOperationNumber(); | ||
| } | ||
| } | ||
|
|
@@ -170,7 +178,7 @@ export class CreateDialogComponent implements OnInit { | |
| items.splice(index, 1); | ||
| return items; | ||
| }); | ||
| if (this.operations().length === 0) this.addValidationToOperationNumber(); | ||
| } | ||
|
|
||
| addValidationToOperationNumber() { | ||
|
|
@@ -217,8 +225,12 @@ export class CreateDialogComponent implements OnInit { | |
| onlySelf: true, | ||
| }); | ||
| } | ||
|
|
||
| this.operationNumberFormControl.reset(''); | ||
| this.operationNumberFormControl.markAsPristine(); | ||
|
There was a problem hiding this comment. this and the following line should be redundant, see https://angular.dev/api/forms/FormControl -> reset Also check line 208, that shouldn't be necessary anymore either |
||
| this.operationNumberFormControl.markAsUntouched(); | ||
| } | ||
|
|
||
| async create(): Promise<void> { | ||
| let failed = false; | ||
| for (const operation of this.operations()) { | ||
|
|
@@ -237,4 +249,33 @@ export class CreateDialogComponent implements OnInit { | |
| } | ||
| if (!failed) this.dialog.close(); | ||
| } | ||
|
|
||
| primaryActionLabel = computed(() => { | ||
|
There was a problem hiding this comment. fields belong at the beginning of the class to the others 😊 |
||
| return this.primaryAction() === 'ADD_CREATE' | ||
| ? this.translate.instant(TranslationConstants.CREATE_DIALOG.CREATE) | ||
| : this.translate.instant(TranslationConstants.CREATE_DIALOG.ADD); | ||
| }); | ||
|
|
||
| canAdd = () => !this.isLoading() && this.canAddOperation(); | ||
|
|
||
| canCreate = () => !this.isLoading() && (this.operations().length > 0 || this.canAddOperation()); | ||
|
|
||
| canRun = (a: Action) => (a === 'ADD_CREATE' ? this.canCreate() : this.canAdd()); | ||
|
|
||
| dropdownDisabled = () => !this.canRun('ADD_CREATE') && !this.canRun('ADD_ONLY'); | ||
|
|
||
| onPrimaryClick = async () => { await this.performAction(this.primaryAction()); }; | ||
|
|
||
| onSelectAction = (a: Action) => { this.primaryAction.set(a); }; | ||
|
|
||
| isSelected = (a: Action) => this.primaryAction() === a; | ||
|
|
||
| private async performAction(a: Action): Promise<void> { | ||
| if (a === 'ADD_CREATE') { | ||
| if (this.canAddOperation()) this.addOperation(); | ||
| if (this.operations().length > 0) await this.create(); | ||
| return; | ||
| } | ||
| if (this.canAddOperation()) this.addOperation(); | ||
|
There was a problem hiding this comment. either make this if-else and remove the return or use the early return and remove the second if, this is half of both options 😅 |
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not needed anymore? if yes, why?