Add split button to 'create dialog' #663
Open
+189
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1nf0rmagician
requested changes
Oct 5, 2025
| matInput | ||
| [formControl]="operationNumberFormControl" | ||
| [(ngModel)]="operationNumber" | ||
| [disabled]="isLoading()" |
There was a problem hiding this comment.
Is this not needed anymore? if yes, why?
| <mat-menu #actionMenu="matMenu"> | ||
| <button | ||
| mat-menu-item | ||
| (click)="onSelectAction('ADD_CREATE')" |
There was a problem hiding this comment.
I think this would make a nice little enum, don't you think? 🤔
| if (!failed) this.dialog.close(); | ||
| } | ||
|
|
||
| primaryActionLabel = computed(() => { |
There was a problem hiding this comment.
fields belong at the beginning of the class to the others 😊
| } | ||
|
|
||
| this.operationNumberFormControl.reset(''); | ||
| this.operationNumberFormControl.markAsPristine(); |
There was a problem hiding this comment.
this and the following line should be redundant, see https://angular.dev/api/forms/FormControl -> reset
Also check line 208, that shouldn't be necessary anymore either
| if (this.operations().length > 0) await this.create(); | ||
| return; | ||
| } | ||
| if (this.canAddOperation()) this.addOperation(); |
There was a problem hiding this comment.
either make this if-else and remove the return or use the early return and remove the second if, this is half of both options 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the old
+button with a split button that exposes two actions:Add + Createunder the hood. It adds the current operation (if valid) and immediately creates all queued operations. If the form is invalid but there are already queued operations, it still creates those.The right-hand arrow only selects which action the left button executes. Selection doesn't execute. This streamlines the common case (one order + one operation) while keeping the rare multi-operation flow via
Add.Screenshots