Skip to content

fix: automatic playback to fail when play audio for not exist file #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: automatic playback to fail when play audio for not exist file #764

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f28d4c9
fix: automatic playback to fail when play audio for not exist file
xiaoxustudio Aug 29, 2025
205dab7
chore: add audio path to error log
xiaoxustudio Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/webgal/src/Core/gameScripts/playEffect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,11 @@ export const playEffect = (sentence: ISentence): IPerform => {
}
}
};
seElement.addEventListener('error', (e) => {
logger.error(`播放效果音失败: ${url}`);
// 播放失败提前结束
seElement.onended?.(e);
});
Comment on lines +103 to +107
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Calling seElement.onended from the error event handler creates a tight coupling between two semantically different events. This can be brittle if the onended handler's logic changes in the future to be more specific to successful playback completion.

Furthermore, the loop that is implicitly called (inside the onended handler) is inefficient and potentially unsafe if the list of performances is modified during iteration.

A better approach is to implement the cleanup logic directly in the error handler using find() to safely locate and clean up the performance object. This decouples the error handling from the onended event and is more robust.

        seElement.addEventListener('error', (e) => {
          logger.error(`播放效果音失败: ${url}`);
          // 播放失败提前结束
          const perf = WebGAL.gameplay.performController.performList.find(
            (p) => p.performName === performInitName
          );
          if (perf) {
            isOver = true;
            perf.stopFunction();
            WebGAL.gameplay.performController.unmountPerform(perf.performName);
          }
        });

}, 1);
}),
};
Expand Down