fix: automatic playback to fail when play audio for not exist file

[xiaoxustudio]

fixes : #752

[gemini-code-assist]

Summary of Changes

Hello @xiaoxustudio, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where sound effect playback failures could disrupt the application's flow. By introducing error handling for audio elements, it ensures that the system can gracefully recover from playback errors, improving overall stability and user experience.

Highlights

• Sound Effect Playback Reliability: Implemented robust error handling for sound effect playback by adding an 'error' event listener to the audio element. This ensures that if a sound effect fails to load or play, the issue is logged, and the playback process is gracefully terminated, preventing potential hangs or unexpected behavior.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds error handling for sound effect playback, which is a good improvement. When a sound effect fails to load, it now correctly cleans up and allows auto-play to proceed. I've added one suggestion to improve the implementation of the error handler to make it more robust and maintainable by decoupling it from the onended event and using a safer method to find the performance object.

[gemini-code-assist]

Calling seElement.onended from the error event handler creates a tight coupling between two semantically different events. This can be brittle if the onended handler's logic changes in the future to be more specific to successful playback completion.

Furthermore, the loop that is implicitly called (inside the onended handler) is inefficient and potentially unsafe if the list of performances is modified during iteration.

A better approach is to implement the cleanup logic directly in the error handler using find() to safely locate and clean up the performance object. This decouples the error handling from the onended event and is more robust.

        seElement.addEventListener('error', (e) => {
          logger.error(`播放效果音失败: ${url}`);
          // 播放失败提前结束
          const perf = WebGAL.gameplay.performController.performList.find(
            (p) => p.performName === performInitName
          );
          if (perf) {
            isOver = true;
            perf.stopFunction();
            WebGAL.gameplay.performController.unmountPerform(perf.performName);
          }
        });