-
Notifications
You must be signed in to change notification settings - Fork 62
[ModelicaSystemDoE] use OMCPath #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
syntron
wants to merge
101
commits into
OpenModelica:master
Choose a base branch
from
syntron:ModelicaSystemDoE_use_OMCPath
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[ModelicaSystemDoE] use OMCPath #333
syntron
wants to merge
101
commits into
OpenModelica:master
from
syntron:ModelicaSystemDoE_use_OMCPath
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2f58334
to
917540f
Compare
This was referenced Aug 14, 2025
Open
* not working: 3.10 * working: 3.12
* use modified pathlib.Path as OMCPath
* this is scripting output and, thus, it cannot be parsed
see commit ID: aa74b36 - [OMCPath] add more functionality and docstrings
* differentiate between * Python >= 3.12 uses OMCPath based on OMC for filesystem operation * Python < 3.12 uses a pathlib.Path based implementation which is limited to OMCProcessLocal
* define file name based on result file name & Path * simplify code
* allow different ways to define the path
remove pathlib - use OMCPath and (for type hints) os.PathLike
…te() * no dependency loop OMCsessionZMQ => OMCProcess* => OMCSessionZMQ * check if model executable exists will be handled via ModelicaSystemCmd
917540f
to
36443e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use OMCPath within ModelicaSystemDoE - this allows to run DoEs also on docker or WSL
needs PR #312 and PR #324