ModelicaSystemCMD - use OMCPath #324
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sonyoyo feel free to also test this PR - it should allow you to use ModelicaSystem in combination with OMC in WSL Test case to check: Please keep in mind that Python >= 3.12 is needed! |
syntron
force-pushed
the
ModelicaSystemCmd_use_OMCPath
branch
from
80f5c96 to
f469523
Compare
syntron
force-pushed
the
ModelicaSystemCmd_use_OMCPath
branch
from
f469523 to
62cb4d3
Compare
syntron
force-pushed
the
ModelicaSystemCmd_use_OMCPath
branch
from
62cb4d3 to
2616a18
Compare
syntron
force-pushed
the
ModelicaSystemCmd_use_OMCPath
branch
from
2616a18 to
890401c
Compare
* not working: 3.10 * working: 3.12
* use modified pathlib.Path as OMCPath
* this is scripting output and, thus, it cannot be parsed
* define file name based on result file name & Path * simplify code
* allow different ways to define the path
remove pathlib - use OMCPath and (for type hints) os.PathLike
…te() * no dependency loop OMCsessionZMQ => OMCProcess* => OMCSessionZMQ * check if model executable exists will be handled via ModelicaSystemCmd
syntron
force-pushed
the
ModelicaSystemCmd_use_OMCPath
branch
from
890401c to
eea4a5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use OMCPath in ModelicaSystemCMD - this allows to run ModelicaSystem simulations using docker or WSL
Please check
tests.test_ModelicaSystem.test_getSolutions_dockerfor an exampleBased on PR #322
Additional requirements: PR #331 and PR #332