ModelicaSystem - rewrite set*() functions #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntron
force-pushed
the
ModelicaSystem_rewrite_set_functions
branch
2 times, most recently
from
326d644 to
817f20d
Compare
syntron
force-pushed
the
ModelicaSystem_rewrite_set_functions
branch
3 times, most recently
from
d9f992a to
844140c
Compare
…ents * fix some type hint issues in setInput() * prepare for definition via dictionary replacing 'a=b' and '[a=b, c=d]' style
* rename from setMethodHelper() * use _prepare_inputdata() * cleanup code to align with new input as dict[str, str] * setInput() is a special case
* replace eval() with ast.literal_eval() as a saver version * use _prepare_input_data() * simplify code
This method is used to set input values. It can be called with a sequence of input name and assigning corresponding values as arguments as show in the example below. Compared to other set*() methods this is a special case as value could be a list of tuples - these are converted to a string in _prepare_input_data() and restored here via ast.literal_eval().
syntron
force-pushed
the
ModelicaSystem_rewrite_set_functions
branch
from
844140c to
d78fafd
Compare
syntron
force-pushed
the
ModelicaSystem_rewrite_set_functions
branch
from
d78fafd to
4fa05f1
Compare
syntron
force-pushed
the
ModelicaSystem_rewrite_set_functions
branch
2 times, most recently
from
0593439 to
30cb70e
Compare
…able * if this happens, the result would be unexpected * fail early, fail hard to indicate this to the user * simplify code
syntron
force-pushed
the
ModelicaSystem_rewrite_set_functions
branch
from
9febb2f to
0a89151
Compare
adeas31
approved these changes
Aug 15, 2025
This was referenced Aug 15, 2025
syntron
added a commit
to syntron/OMPython
that referenced
this pull request
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set function uses (list of) strings as 'key=value' pairs - this can be converted to the usage of dictionaries
This PR does the modification for all set*() methods in ModelicaSystem including setInputs()
If this PR is included PR #307 can be closed as invalid; the method isParameterChangeable() is also modified here