Skip to content

Conversation

devhl-labs
Copy link
Contributor

@devhl-labs devhl-labs commented Mar 27, 2021

Adding NRT option and templates for experimental library.

The commits between the verified commits should be undone by 5b7c5da. Sorry for this. My fork got a bit messy because my last pr was from my master, and I had my template files in httpclient instead of httpclient-experimental folder.

@wing328 @Blackclaws

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@devhl-labs
Copy link
Contributor Author

@wing328 Can i get some input here? I can move this back to the other branch if that helps. I've got some other changes to make but there's quite a bit here to see.

@wing328
Copy link
Member

wing328 commented Apr 1, 2021

@devhl-labs can you please PM me via Slack to further discuss this? Thanks again for the PR to improve the C# generators.

@lucamazzanti
Copy link

Is this PR an obsolete alternative to #9235?

@Blackclaws
Copy link
Contributor

Its a more involved rewrite of the csharp client and the null reference part was split out. We'll actually need to review that.

@devhl-labs devhl-labs closed this Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants