Skip to content

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 12, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • Fix JS test using baseName in default value
  • re-enable test in travis

@wing328 wing328 added this to the 3.0.0 milestone May 12, 2018
@wing328
Copy link
Member Author

wing328 commented May 12, 2018

cc @frol @cliffano

@wing328
Copy link
Member Author

wing328 commented May 13, 2018

JS Tests passed via Travis CI

@wing328 wing328 merged commit d80e295 into master May 13, 2018
wing328 added a commit that referenced this pull request May 13, 2018
@wing328 wing328 mentioned this pull request May 13, 2018
4 tasks
@wing328 wing328 deleted the fix_js branch May 13, 2018 07:24
wing328 added a commit that referenced this pull request May 13, 2018
frecco75 pushed a commit to galeries-lafayette/openapi-generator that referenced this pull request Sep 29, 2020
feat(kotlin-spring): add responseEntity option - PEC-6512

Approved-by: Benjamin HENIQUE <[email protected]>
Approved-by: Yves DEKERLE <[email protected]>
Thecrazyskull pushed a commit to Thecrazyskull/openapi-generator that referenced this pull request Nov 26, 2020
AbstractKotlinCodegen: always include data class body if model has pa…
wing328 pushed a commit that referenced this pull request Jan 2, 2022
ronanwatkins added a commit to ronanwatkins/openapi-generator that referenced this pull request Mar 1, 2022
wing328 pushed a commit that referenced this pull request Jan 9, 2024
* Rust Server - Axum based (#5)

* Fix typo

* Address comment

* Address comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant