Use ConfigureAwait when booting up input stream. #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Razor initializes O#'s language server in-proc in Visual Studio and because the `pipeReader.ReadAsync` doesn't utilize `ConfigureAwait(false)` it attempts to only ever read information on the main thread which is a problem if a feature such as light bulbs or go-to-definition require.
TanayParikh
approved these changes
Sep 9, 2020
david-driscoll
approved these changes
Sep 10, 2020
ya I figured. I try to default to using ConfigureAwait(false) but to be frank this is the first time when it's actually ever bitten me 😄 |
|
So the test failures seem legit... why they're legit I do not know, however I will figure it out tonight. |
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
==========================================
- Coverage 75.48% 70.40% -5.09%
==========================================
Files 441 441
Lines 12774 12774
Branches 1179 1179
==========================================
- Hits 9643 8994 -649
- Misses 3131 3367 +236
- Partials 0 413 +413
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipeReader.ReadAsyncdoesn't utilizeConfigureAwait(false)it attempts to only ever read information on the main thread which is a problem if a feature such as light bulbs or go-to-definition require.