Use ConfigureAwait when booting up input stream. (#354)

* Use ConfigureAwait when booting up input stream.

- Razor initializes O#'s language server in-proc in Visual Studio and because the `pipeReader.ReadAsync` doesn't utilize `ConfigureAwait(false)` it attempts to only ever read information on the main thread which is a problem if a feature such as light bulbs or go-to-definition require.

* ConfigureAwait(false) all the things

Co-authored-by: David Driscoll <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Author: 3 people

src/Client/LanguageClient.cs

@@ -97,7 +97,7 @@ public static Task<LanguageClient> From(Action<LanguageClientOptions> optionsAct
         public static async Task<LanguageClient> From(LanguageClientOptions options, IServiceProvider outerServiceProvider, CancellationToken cancellationToken)
         {
             var server = Create(options, outerServiceProvider);
-            await server.Initialize(cancellationToken);
+            await server.Initialize(cancellationToken).ConfigureAwait(false);
             return server;
         }
 
@@ -261,10 +261,10 @@ await LanguageProtocolEventingHelper.Run(
                 (handler, ct) => handler.OnInitialize(this, @params, ct),
                 _concurrency,
                 token
-            );
+            ).ConfigureAwait(false);
 
             _connection.Open();
-            var serverParams = await SendRequest(ClientSettings, token);
+            var serverParams = await SendRequest(ClientSettings, token).ConfigureAwait(false);
             _receiver.Initialized();
 
             ServerSettings = serverParams;
@@ -276,7 +276,7 @@ await LanguageProtocolEventingHelper.Run(
                 (handler, ct) => handler.OnInitialized(this, @params, serverParams, ct),
                 _concurrency,
                 token
-            );
+            ).ConfigureAwait(false);
 
             // post init
 
@@ -290,7 +290,7 @@ await LanguageProtocolEventingHelper.Run(
                 (handler, ct) => handler.OnStarted(this, ct),
                 _concurrency,
                 token
-            );
+            ).ConfigureAwait(false);
 
             _instanceHasStarted.Started = true;
 
@@ -361,11 +361,11 @@ public async Task Shutdown()
         {
             if (_connection.IsOpen)
             {
-                await this.RequestShutdown();
+                await this.RequestShutdown().ConfigureAwait(false);
                 this.SendExit();
             }
 
-            await _connection.StopAsync();
+            await _connection.StopAsync().ConfigureAwait(false);
             _connection.Dispose();
         }
 

src/Dap.Client/DebugAdapterClient.cs

@@ -76,7 +76,7 @@ public static Task<DebugAdapterClient> From(Action<DebugAdapterClientOptions> op
         public static async Task<DebugAdapterClient> From(DebugAdapterClientOptions options, IServiceProvider outerServiceProvider, CancellationToken cancellationToken)
         {
             var server = Create(options, outerServiceProvider);
-            await server.Initialize(cancellationToken);
+            await server.Initialize(cancellationToken).ConfigureAwait(false);
             return server;
         }
 
@@ -127,12 +127,12 @@ await DebugAdapterEventingHelper.Run(
                 (handler, ct) => handler.OnInitialize(this, ClientSettings, ct),
                 _concurrency,
                 token
-            );
+            ).ConfigureAwait(false);
 
             RegisterCapabilities(ClientSettings);
 
             _connection.Open();
-            var serverParams = await this.RequestDebugAdapterInitialize(ClientSettings, token);
+            var serverParams = await this.RequestDebugAdapterInitialize(ClientSettings, token).ConfigureAwait(false);
 
             ServerSettings = serverParams;
             _receiver.Initialized();
@@ -144,7 +144,7 @@ await DebugAdapterEventingHelper.Run(
                 (handler, ct) => handler.OnInitialized(this, ClientSettings, ServerSettings, ct),
                 _concurrency,
                 token
-            );
+            ).ConfigureAwait(false);
 
             await _initializedComplete.ToTask(token);
 
@@ -155,22 +155,13 @@ await DebugAdapterEventingHelper.Run(
                 (handler, ct) => handler.OnStarted(this, ct),
                 _concurrency,
                 token
-            );
+            ).ConfigureAwait(false);
 
             _instanceHasStarted.Started = true;
         }
 
         async Task<Unit> IRequestHandler<InitializedEvent, Unit>.Handle(InitializedEvent request, CancellationToken cancellationToken)
         {
-            await DebugAdapterEventingHelper.Run(
-                _initializedDelegates,
-                (handler, ct) => handler(this, ClientSettings, ServerSettings, ct),
-                _initializedHandlers.Union(_collection.Select(z => z.Handler).OfType<IOnDebugAdapterClientInitialized>()),
-                (handler, ct) => handler.OnInitialized(this, ClientSettings, ServerSettings, ct),
-                _concurrency,
-                cancellationToken
-            );
-
             _initializedComplete.OnNext(request);
             _initializedComplete.OnCompleted();
             return Unit.Value;

src/Dap.Server/DebugAdapterServer.cs

@@ -78,7 +78,7 @@ public static Task<DebugAdapterServer> From(Action<DebugAdapterServerOptions> op
         public static async Task<DebugAdapterServer> From(DebugAdapterServerOptions options, IServiceProvider outerServiceProvider, CancellationToken cancellationToken)
         {
             var server = Create(options, outerServiceProvider);
-            await server.Initialize(cancellationToken);
+            await server.Initialize(cancellationToken).ConfigureAwait(false);
             return server;
         }
 
@@ -125,7 +125,7 @@ public async Task Initialize(CancellationToken token)
             {
                 try
                 {
-                    await _initializingTask;
+                    await _initializingTask.ConfigureAwait(false);
                 }
                 catch
                 {
@@ -139,15 +139,15 @@ public async Task Initialize(CancellationToken token)
             try
             {
                 _initializingTask = _initializeComplete.ToTask(token);
-                await _initializingTask;
+                await _initializingTask.ConfigureAwait(false);
                 await DebugAdapterEventingHelper.Run(
                     _startedDelegates,
                     (handler, ct) => handler(this, ct),
                     _startedHandlers.Union(_collection.Select(z => z.Handler).OfType<IOnDebugAdapterServerStarted>()),
                     (handler, ct) => handler.OnStarted(this, ct),
                     _concurrency,
                     token
-                );
+                ).ConfigureAwait(false);
                 _instanceHasStarted.Started = true;
 
                 this.SendDebugAdapterInitialized(new InitializedEvent());
@@ -178,7 +178,7 @@ await DebugAdapterEventingHelper.Run(
                 (handler, ct) => handler.OnInitialize(this, request, ct),
                 _concurrency,
                 cancellationToken
-            );
+            ).ConfigureAwait(false);
 
             _receiver.Initialized();
 
@@ -230,7 +230,7 @@ await DebugAdapterEventingHelper.Run(
                 (handler, ct) => handler.OnInitialized(this, request, response, ct),
                 _concurrency,
                 cancellationToken
-            );
+            ).ConfigureAwait(false);
 
             _initializeComplete.OnNext(response);
             _initializeComplete.OnCompleted();

src/Dap.Shared/DapResponseRouter.cs

@@ -117,7 +117,7 @@ public async Task<TResponse> Returning<TResponse>(CancellationToken cancellation
 
                 try
                 {
-                    var result = await tcs.Task;
+                    var result = await tcs.Task.ConfigureAwait(false);
                     if (typeof(TResponse) == typeof(Unit))
                     {
                         return (TResponse) (object) Unit.Value;
@@ -131,7 +131,7 @@ public async Task<TResponse> Returning<TResponse>(CancellationToken cancellation
                 }
             }
 
-            public async Task ReturningVoid(CancellationToken cancellationToken) => await Returning<Unit>(cancellationToken);
+            public async Task ReturningVoid(CancellationToken cancellationToken) => await Returning<Unit>(cancellationToken).ConfigureAwait(false);
         }
     }
 }

src/Dap.Testing/DebugAdapterProtocolTestBase.cs

@@ -80,7 +80,7 @@ Action<DebugAdapterServerOptions> serverOptionsAction
             return await Observable.FromAsync(_client.Initialize).ForkJoin(
                 Observable.FromAsync(_server.Initialize),
                 (a, b) => ( _client, _server )
-            ).ToTask(CancellationToken);
+            ).ToTask(CancellationToken).ConfigureAwait(false);
         }
     }
 }

src/Dap.Testing/DebugAdapterServerTestBase.cs

@@ -46,7 +46,7 @@ protected virtual async Task<IDebugAdapterClient> InitializeClient(Action<DebugA
 
             Disposable.Add(_client);
 
-            await _client.Initialize(CancellationToken);
+            await _client.Initialize(CancellationToken).ConfigureAwait(false);
 
             return _client;
         }

src/JsonRpc.Testing/JsonRpcServerTestBase.cs

@@ -71,7 +71,7 @@ Action<JsonRpcServerOptions> serverOptionsAction
                 }, CancellationToken
             );
 
-            await Task.WhenAll(clientTask, serverTask);
+            await Task.WhenAll(clientTask, serverTask).ConfigureAwait(false);
             _client = clientTask.Result;
             _server = serverTask.Result;
 

src/JsonRpc.Testing/SettlePipeline.cs

@@ -16,7 +16,7 @@ async Task<R> IPipelineBehavior<T, R>.Handle(T request, CancellationToken cancel
             _settler.OnStartRequest();
             try
             {
-                return await next();
+                return await next().ConfigureAwait(false);
             }
             finally
             {

src/JsonRpc/DelegatingHandlers.cs

@@ -39,7 +39,7 @@ public Request(Func<TParams, Task> handler) : this((a, ct) => handler(a))
             async Task<Unit> IRequestHandler<TParams, Unit>.
                 Handle(TParams request, CancellationToken cancellationToken)
             {
-                await _handler(request, cancellationToken);
+                await _handler(request, cancellationToken).ConfigureAwait(false);
                 return Unit.Value;
             }
         }
@@ -62,7 +62,7 @@ public Notification(Action<TParams, CancellationToken> handler) : this(
 
             async Task<Unit> IRequestHandler<TParams, Unit>.Handle(TParams request, CancellationToken cancellationToken)
             {
-                await _handler(request, cancellationToken);
+                await _handler(request, cancellationToken).ConfigureAwait(false);
                 return Unit.Value;
             }
         }

src/JsonRpc/DelegatingJsonNotificationHandler.cs

@@ -14,7 +14,7 @@ public class DelegatingJsonNotificationHandler : IJsonRpcNotificationHandler<Del
 
         public async Task<Unit> Handle(DelegatingNotification<JToken> request, CancellationToken cancellationToken)
         {
-            await _handler.Invoke(request.Value, cancellationToken);
+            await _handler.Invoke(request.Value, cancellationToken).ConfigureAwait(false);
             return Unit.Value;
         }
     }