[FIX] purge uninstalled uninstallable modules instead of deleting #490
Conversation
|
👍 |
| [auth_supplier](auth_supplier/) | 9.0.2.0.0 | Auth Supplier | ||
| [base_custom_info](base_custom_info/) | 9.0.1.0.0 | Add custom field in models | ||
| [base_multi_image](base_multi_image/) | 9.0.1.0.0 | Allow multiple images for database objects | ||
| [base_multi_image](base_multi_image/) | 9.0.1.1.0 | Allow multiple images for database objects |
There was a problem hiding this comment.
FYI the section [//]: # (addons) is auto-generated you don't need add this change.
There was a problem hiding this comment.
In fact, this generates conflicts continuously as now, so please remove it and squash the commits
|
👍 |
|
@hbrunn rebase needed. |
hbrunn
force-pushed
the
9.0-database_cleanup-purge_uninstalled
branch
from
05bab9e to
d3365e1
Compare
hbrunn
force-pushed
the
9.0-database_cleanup-purge_uninstalled
branch
from
d3365e1 to
e1d5737
Compare
|
did someone force-push over the 9.0 branch? My local copy conflicted with it when fetching... |
|
@hbrunn I think @pedrobaeza may have done so, yes (https://twitter.com/PedroMBaeza/status/761595556934410240) |
|
Yes, I did. See #504 |
|
ah, thanks. Missed that while enjoying European High Culture: http://www.wacken.com ;-) |
|
now investigating the CI issues, I have the feeling isolating this addon in the tests rather fixes a symptom than the cause |
|
@gurneyalex yes, thanks. But those work by isolating the module, and I'd like to find out what actually goes wrong in the first place. |
|
👍 Any luck finding out the problem of testing this module in combination with other modules? |
|
@StefanRijnhart yes, the test introduced in the offending commit caused the registry to be reloaded, with quite undefined behavior afterwards because at this point, there's no change signalling and no reloading. So I had to do some trickery to reload the registry, but not really: https://github.com/OCA/server-tools/pull/512/files |
Syncing from upstream OCA/server-tools (12.0)
6 participants
forward port of #489