[FIX] purge uninstalled uninstallable modules instead of deleting #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| purge_line_pool.purge( | ||
| cr, uid, [ | ||
| purge_line_pool.create( | ||
| cr, uid, {'name': module.name}, context=context), |
Member
There was a problem hiding this comment.
It's a style nitpick, but IMO the could would be more readable if the create was done in it's own instruction.
Member
|
👍 |
Contributor
|
👍 |
Member
|
maybe #507 will help in getting a green travis. |
Member
|
#507 is merged. I guess a rebase is needed. |
Member
Author
|
@dreispt how so? |
Member
Member
Author
|
@dreispt that's not how git works. Merging this will just add the extra commit on the python file, the travis definition will be quite unaffected |
Member
Member
|
👍 |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (10.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for module which were installed some time, then uncleanly uninstalled and only afterwards became uninstallable.