Skip to content

fix: build-lint-test workflow dependencies installation #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: build-lint-test workflow dependencies installation #319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build-lint-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
cache: 'yarn'
- run: yarn --immutable --immutable-cache
- run: yarn --immutable
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing only for the node version 22.x and works fine for 18.x and 20.x. But this change will remove the --immutable-cache for the other two versions which are working fine.
Do we want that way?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks more like the build is not working for any version. The v18 and v20 build jobs were aborted because v22 failed.

Copy link

@kanthesha kanthesha Jul 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. yeah, maybe because of v22 aborted. I tried to re-run now; 18.x build successfully. And also checked the eip 1193 PR in the same repo, v18 and v20 build were fine and failed for v22.

18.x & 20.x
Run yarn --immutable --immutable-cache
➤ YN0000: ┌ Resolution step
Resolution step
➤ YN0000: └ Completed in 0s 22[4](https://github.com/MetaMask/eth-json-rpc-middleware/actions/runs/9993141696/job/27619852600?pr=317#step:4:5)ms
➤ YN0000: ┌ Fetch step
Fetch step
➤ YN0000: └ Completed in 0s 2[5](https://github.com/MetaMask/eth-json-rpc-middleware/actions/runs/9993141696/job/27619852600?pr=317#step:4:6)5ms
➤ YN0000: ┌ Link step
Link step
➤ YN0000: └ Completed in 4s 55ms
no allowed lifecycle scripts found in configuration
running lifecycle scripts for top level package
➤ YN0000: Done with warnings in 5s 5[8](https://github.com/MetaMask/eth-json-rpc-middleware/actions/runs/9993141696/job/27619852600?pr=317#step:4:10)3ms

In case of v22, the link step is failing!
22.x

Run yarn --immutable --immutable-cache
➤ YN0000: ┌ Resolution step
Resolution step
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
Fetch step
➤ YN0000: └ Completed
➤ YN0000: ┌ Link step
Link step

- run: yarn build
- name: Require clean working directory
shell: bash
Expand All @@ -57,7 +57,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
cache: 'yarn'
- run: yarn --immutable --immutable-cache
- run: yarn --immutable
- run: yarn lint
- name: Validate RC changelog
if: ${{ startsWith(github.head_ref, 'release/') }}
Expand Down Expand Up @@ -88,7 +88,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
cache: 'yarn'
- run: yarn --immutable --immutable-cache
- run: yarn --immutable
- run: yarn test
- name: Require clean working directory
shell: bash
Expand Down