fix: build-lint-test workflow dependencies installation #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptodev-2s
changed the title
kanthesha
reviewed
Jul 18, 2024
| node-version: ${{ matrix.node-version }} | ||
| cache: 'yarn' | ||
| - run: yarn --immutable --immutable-cache | ||
| - run: yarn --immutable |
There was a problem hiding this comment.
The build is failing only for the node version 22.x and works fine for 18.x and 20.x. But this change will remove the --immutable-cache for the other two versions which are working fine.
Do we want that way?
There was a problem hiding this comment.
It looks more like the build is not working for any version. The v18 and v20 build jobs were aborted because v22 failed.
There was a problem hiding this comment.
Ok. yeah, maybe because of v22 aborted. I tried to re-run now; 18.x build successfully. And also checked the eip 1193 PR in the same repo, v18 and v20 build were fine and failed for v22.
18.x & 20.x
Run yarn --immutable --immutable-cache
➤ YN0000: ┌ Resolution step
Resolution step
➤ YN0000: └ Completed in 0s 22[4](https://github.com/MetaMask/eth-json-rpc-middleware/actions/runs/9993141696/job/27619852600?pr=317#step:4:5)ms
➤ YN0000: ┌ Fetch step
Fetch step
➤ YN0000: └ Completed in 0s 2[5](https://github.com/MetaMask/eth-json-rpc-middleware/actions/runs/9993141696/job/27619852600?pr=317#step:4:6)5ms
➤ YN0000: ┌ Link step
Link step
➤ YN0000: └ Completed in 4s 55ms
no allowed lifecycle scripts found in configuration
running lifecycle scripts for top level package
➤ YN0000: Done with warnings in 5s 5[8](https://github.com/MetaMask/eth-json-rpc-middleware/actions/runs/9993141696/job/27619852600?pr=317#step:4:10)3ms
In case of v22, the link step is failing!
22.x
Run yarn --immutable --immutable-cache
➤ YN0000: ┌ Resolution step
Resolution step
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
Fetch step
➤ YN0000: └ Completed
➤ YN0000: ┌ Link step
Link step
|
I pushed up a PR to upgrade Node and fix CI here: #321 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Build, Lint, and Test workflow by replacing
yarn --immutable --immutable-cachewithyarn --immutable