Skip to content

Conversation

@MajorLift
Copy link
Contributor

Explanation

Records CHANGELOG entries from @metamask/json-rpc-engine and @metamask/json-rpc-middleware-stream migrations under "Unreleased" headers for reference during the next version release.

  • Records updates made to the @metamask/json-rpc-engine and @metamask/json-rpc-middleware-stream packages since its last release, and during the migration process.
  • Lists these migrations as ADDED changes.
  • Records version bumps of the migrated packages in downstream repos.
  • Records changes made to downstream repos.

References

Changelog

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@MajorLift MajorLift added the team-wallet-framework Deprecated: Please use `team-core-platform` instead. label Nov 7, 2023
@MajorLift MajorLift self-assigned this Nov 7, 2023
@MajorLift MajorLift requested review from a team as code owners November 7, 2023 19:23
@MajorLift MajorLift force-pushed the 231107-record-changelog-migrations-json-rpc-engine,middleware-stream branch 2 times, most recently from f7237f6 to a81dcf5 Compare November 7, 2023 19:41
@MajorLift MajorLift force-pushed the 231107-record-changelog-migrations-json-rpc-engine,middleware-stream branch from 91b6b62 to fa6f2b6 Compare November 7, 2023 20:27
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a few that were potentially missing.

mcmire
mcmire previously approved these changes Nov 7, 2023
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MajorLift MajorLift requested a review from mcmire November 8, 2023 15:37
@MajorLift MajorLift merged commit f647ce0 into main Nov 8, 2023
@MajorLift MajorLift deleted the 231107-record-changelog-migrations-json-rpc-engine,middleware-stream branch November 8, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-wallet-framework Deprecated: Please use `team-core-platform` instead.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants