Release 89.0.0 #2004
Merged
Release 89.0.0 #2004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BelfordZ
force-pushed
the
release/89.0.0
branch
from
de46e6c to
4dd34f7
Compare
adonesky1
reviewed
Nov 7, 2023
adonesky1
reviewed
Nov 7, 2023
adonesky1
reviewed
Nov 7, 2023
BelfordZ
commented
Nov 7, 2023
BelfordZ
commented
Nov 7, 2023
adonesky1
reviewed
Nov 7, 2023
BelfordZ
commented
Nov 7, 2023
jiexi
reviewed
Nov 7, 2023
Co-authored-by: jiexi <[email protected]>
jiexi
previously approved these changes
Nov 7, 2023
mcmire
reviewed
Nov 7, 2023
| - Bump @metamask/utils from 8.1.0 to 8.2.0 ([#1957](https://github.com/MetaMask/core/pull/1957)) | ||
|
|
||
| ### Fixed | ||
| - Fix network nicknames ([#2000](https://github.com/MetaMask/core/pull/2000)) |
Contributor
There was a problem hiding this comment.
What about nicknames got fixed? Is it that they're now available, and if so, available how? Also, it's not just nickname but theoretically any other network configuration information yes? It would be nice to be more clear here for other consumers.
|
|
||
| ### Fixed | ||
| - Fix network nicknames ([#2000](https://github.com/MetaMask/core/pull/2000)) | ||
| - Fix addEthereumChain showing switch ethereum chain dialog ([#2000](https://github.com/MetaMask/core/pull/2000)) |
Contributor
There was a problem hiding this comment.
Is that it did show it before and does not now, or the opposite? It would be nice to be more clear here for other consumers.
BelfordZ
commented
Nov 7, 2023
BelfordZ
commented
Nov 7, 2023
adonesky1
approved these changes
Nov 7, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Release queued request controller with fixes for network nickname & addEthereumChain
References
Changelog
Checklist