feat(firestore): add support of emulator to run system tests on emulator #2
Conversation
tests/system/test_system.py
Outdated
| MISSING_DOCUMENT = "No document to update: " | ||
| DOCUMENT_EXISTS = "Document already exists: " | ||
| UNIQUE_RESOURCE_ID = unique_resource_id("-") | ||
| FIRESTORE_EMULATOR_HOST = "FIRESTORE_EMULATOR_HOST" |
There was a problem hiding this comment.
I don't think we need this constant. It's used once. As it's name completely repeats the value itself, there is no practical use in it.
There was a problem hiding this comment.
It is need as chris also used here, the pattern that they follow is one is for internal variable and one is for variable which user use like here also https://github.com/q-logic/python-firestore/blob/160d7d11564a137f06faced96c21f967411bfc55/google/cloud/firestore_v1/client.py#L57
I am trying to use the same which already declared by chris.
mf2199
left a comment
mf2199
left a comment
There was a problem hiding this comment.
Support Ilya's comment but otherwise looks fine.
tests/system/test_system.py
Outdated
| MISSING_DOCUMENT = "No document to update: " | ||
| DOCUMENT_EXISTS = "Document already exists: " | ||
| UNIQUE_RESOURCE_ID = unique_resource_id("-") | ||
| FIRESTORE_EMULATOR_HOST = "FIRESTORE_EMULATOR_HOST" |
|
Added test_utils folder as it has dependency and it is already there for big table and datastore so I am not going to add into their respective PR, also i will mention in Public PR to update nox file to add |
… into firestore_issue_5
… into firestore_issue_5
… into firestore_issue_5
* feat: implement limit to last feature * simplify test * add more tests and de-deprecate Collection.get() method * fix unit tests * reverse should be used in get() only when limit_to_last set * cosmetic changes * use bool instead of int for _limit_to_last attr * fix comments * fix comments * Apply suggestions from code review Co-authored-by: BenWhitehead <[email protected]> * add notes about mutually exclusivity Co-authored-by: BenWhitehead <[email protected]> Co-authored-by: Christopher Wilcox <[email protected]>
Co-authored-by: Christopher Wilcox <[email protected]>
Towards [bigtable issue 5]