Skip to content

fix(firestore): use specific naming convention #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HemangChothani merged 2 commits into from
Jun 29, 2020
Merged

fix(firestore): use specific naming convention #58

HemangChothani merged 2 commits into from
Jun 29, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Jun 5, 2020 •
edited
Loading

Towards #56

@HemangChothani HemangChothani requested a review from crwilcox June 5, 2020 12:39
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2020
@HemangChothani HemangChothani mentioned this pull request Jun 8, 2020
Closed
@HemangChothani HemangChothani merged commit c97a168 into googleapis:master Jun 29, 2020
@tseaver
Copy link
Contributor

tseaver commented Aug 20, 2020

This PR needs to be ported to the new master branch (used to be v2-staging).

@HemangChothani HemangChothani mentioned this pull request Aug 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HemangChothani @tseaver @crwilcox @googlebot