Frontend peek sequencing -- emit_optimizer_notices also for COPY TO S3
#34290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggevay
changed the title
emit_optimizer_notices also for COPY TOemit_optimizer_notices also for COPY TO S3
aljoscha
approved these changes
Nov 27, 2025
Contributor
aljoscha
left a comment
aljoscha
left a comment
There was a problem hiding this comment.
looking good! that is the last two commits of this one.
| global_lir_plan, | ||
| source_ids, | ||
| } => { | ||
| let (df_desc, df_meta) = global_lir_plan.unapply(); |
Contributor
There was a problem hiding this comment.
might have to be _df_meta?
Contributor
Author
There was a problem hiding this comment.
This is used in the next commit: passed in to emit_optimizer_notices.
| /// # Panics | ||
| /// | ||
| /// Panics if the dataflow has no sink exports. | ||
| pub fn sink_id(&self) -> GlobalId { |
Contributor
There was a problem hiding this comment.
maybe this also wants to panic when there are more than one sink? but I'm not familiar enough with this code
Contributor
Author
There was a problem hiding this comment.
I think so, yes. I've now made it enforce that we have exactly one sink.
ggevay
force-pushed
the
frontend-peek-copy-to-emit-optimizer-notices
branch
from
3f278af to
e679ba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is on top of both #34283 and #34289. Only the last 2 commits are new.)
This does some refactoring and fixes a minor issue in 2 commits:
Command::ExecuteCopyToto take aDataflowDescriptioninstead ofGlobalLirPlan. (Plus some minor code movement.)emit_optimizer_noticesforCOPY TO.Sorry, I didn't add a test for this. Testing of
COPY TOand notices are hard enough by themselves (COPY TOneeds Testdrive, notices need pgtest), testing the two together seems impossibly hard.