-
Notifications
You must be signed in to change notification settings - Fork 485
Frontend peek sequencing -- graceful handling of dependency drops for slow-path peeks and COPY TO
#34289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend peek sequencing -- graceful handling of dependency drops for slow-path peeks and COPY TO
#34289
Conversation
c10dbe6 to
7a0719b
Compare
| .unwrap_or_terminate("cannot fail to create dataflows"); | ||
| .map_err( | ||
| AdapterError::concurrent_dependency_drop_from_dataflow_creation_error, | ||
| )?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change can possibly affect the old peek sequencing, but I hope that's ok.
7a0719b to
615c9f8
Compare
615c9f8 to
e5e43fa
Compare
|
I think this fixes the issue we just saw in Nightly on main? |
|
Hmm, it doesn't fix |
teskje
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I'll merge this now, because it should improve the situation, but the
(I've checked that Parallel Workload has an ignore for |
e5e43fa to
2f54151
Compare
In my earlier slow-path peek and
COPY TOPRs I conveniently forgot about the dependencies dropping during sequencing problem. Nightly now reminded me of this with somedataflow creation cannot failpanics.This PR makes us gracefully handle this problem, with showing
AdapterError::ConcurrentDependencyDropto the user.Nightly (subset): https://buildkite.com/materialize/nightly/builds/14259
(Temporarily turns on
enable_frontend_peek_sequencingin CI. I'll remove this commit before merging.)