Prepare v0.6.0 #1434

behackl · 2021-05-01T13:42:56Z

Changelog

Added generated changelog
Bumped version to v0.6.0

behackl · 2021-05-01T13:46:21Z

I would still like to get #1430 and #1431 in. Please everyone @ManimCommunity/core check out the generated changelog (as soon as RTD finished the build)!

AntonBallmaier · 2021-05-01T14:38:11Z

docs/source/changelog/0.6.0-changelog.rst

+* Abhijith Muthyala
+* Adam Ryczkowski +
+* Alex Lembcke +
+* Anton Ballmaier +


Suggested change

* Anton Ballmaier +

* Anton Ballmaier

I have authored a patch in 0.5 as well. Other names may be wrong as well?

Can you link the PR? This will help to debug the dev_changelog.py script.

Nvm, I found it:

The issue here is that your name changed between v0.4.0 -> v0.5.0 and v0.5.0 -> v0.6.0 from AntonBallmaier to Anton Ballmaier with a space -- our script works by pulling the author name and comparing author names from the set of past contributors to current contributors with the git shortlog command. I suppose we could do it based on a combination of email/user, but maybe there's a better approach using GitHub's API.

docs/source/changelog/0.6.0-changelog.rst

abhijithmuthyala · 2021-05-01T16:42:10Z

docs/source/changelog/0.6.0-changelog.rst

+   The parameter `path_arc` of :class:`~.Transform` now works with the `.animate` syntax
+
+* `#1364 <https://github.com/ManimCommunity/manim/pull/1364>`__: Added :meth:`~.Mobject.match_points`
+   - Added :func:`~.Mobject.become_points`, which transforms the points, positions and submobjects of a Mobject to match that of the other while keeping style unchanged.


CC @Darylgolden

Suggested change

- Added :func:`~.Mobject.become_points`, which transforms the points, positions and submobjects of a Mobject to match that of the other while keeping style unchanged.

- Added :meth:`~.Mobject.match_points`, which transforms the points, positions and submobjects of a Mobject to match that of the other while keeping style unchanged.

can you change it in the PR title, then behackl would render this again?

I've already taken care of it. 👍

behackl · 2021-05-01T22:54:17Z

I fixed some more broken formatting and fixed a few links; I'm more or less fine with the current state of this. I'll be away for a few hours, everyone with write access can re-run the script though (or push changes to the changelog directly).

Darylgolden · 2021-05-02T01:39:36Z

Also, can I ask how the list of contributors who reviewed PRs is determined? I tried to review several PRs this release, even though I don't have write access.

jsonvillanueva · 2021-05-02T03:06:39Z

Also, can I ask how the list of contributors who reviewed PRs is determined? I tried to review several PRs this release, even though I don't have write access.

https://github.com/ManimCommunity/manim/blob/master/scripts/dev_changelog.py#L92

If you go to the Files changed tab there's a green dropdown button that allows you to make Reviews. I ~~don't~~ think comments are included in the GitHub API request.

Darylgolden · 2021-05-02T03:09:39Z

Also, can I ask how the list of contributors who reviewed PRs is determined? I tried to review several PRs this release, even though I don't have write access.

https://github.com/ManimCommunity/manim/blob/master/scripts/dev_changelog.py#L92

If you go to the Files changed tab there's a green dropdown button that allows you to make Reviews. I don't think comments are included in the GitHub API request.

I'm pretty sure I did that several times.

jsonvillanueva · 2021-05-02T03:47:11Z

I'm pretty sure I did that several times.

I'm not really sure what the issue is. We're not doing any filtering on whether the review is of type approves/request changes/comments and you do appear in at least one REST API query: https://api.github.com/repos/ManimCommunity/manim/pulls/1347/reviews

^This is what the github package is doing https://github.com/PyGithub/PyGithub/blob/master/github/PullRequest.py#L729-L739

Darylgolden · 2021-05-02T04:05:20Z

I initially thought the issue was write access, but there are people without write access in the reviewers list too 😕

Darylgolden · 2021-05-02T04:14:54Z

I also think @hydrobeam reviewed some PRs but isn't included too, such as at #1430

kolibril13 · 2021-05-02T07:07:12Z

Thanks for making the pr, I just saw that my name is also not there in the "have been reviewed" section.

behackl · 2021-05-02T07:10:10Z

For those not in the reviewer list: can you check whether you have a name set in your github profile? If not, then that's the issue. I think we can fix the situation by using the login name if no actual name is set.

kolibril13 · 2021-05-02T07:13:49Z

For those not in the reviewer list: can you check whether you have a name set in your github profile? If not, then that's the issue. I think we can fix the situation by using the login name if no actual name is set.

I did not set my name, but it is set now :)

hydrobeam · 2021-05-02T07:27:26Z

I've also set my name 🚀

naveen521kk · 2021-05-02T07:32:27Z

docs/source/changelog/0.6.0-changelog.rst

+* Aron
+* Aron Fischer


I think both the names are the same right? @cobordism

Darylgolden · 2021-05-02T08:14:50Z

I've set my (fake) name

behackl · 2021-05-02T10:21:19Z

PRs #1434 (obviously) as well as #1282 #1200 #1259 were not yet included in the list because their merge message have either been modified, or because they were merged manually/differently. I've added them now manually.

Also, I've changed the logic of how authors are determined -- it now also uses the GitHub API, the names in the authors and reviewers list should now be consistent.

for more information, see https://pre-commit.ci

jsonvillanueva

I'm approving this in advance with these changes (Gotta make the first PR look great and remove the malformatted bullets); however, I'd like to mention that there could be a more consistent grammar/authoring of this text. As is, it appears to be written by various authors and in some cases there's redundancies between the PR title/body text. We'd be here all day doing nitpicks and the meaning is understood nonetheless... so I'd rather just release this considering the tradeoff.

docs/source/changelog/0.6.0-changelog.rst

… prepare-v0.6.0

for more information, see https://pre-commit.ci

Co-authored-by: Jason Villanueva <[email protected]>

behackl · 2021-05-02T14:58:38Z

I won't regenerate the changelog at this point, I think it is good to go. (Certainly not written uniformly, and some information might be redundant -- but I don't think there is a wide margin for improvement here.)

Pretty impressive work everyone, and thanks for reviewing the changelog! I'll merge and then release soon™️, if you have further comments or remarks, it's either now or never.

behackl added 2 commits May 1, 2021 15:41

version bump

f3f2930

add generated changelog

a20cc98

behackl added the release A tracking issue for changes expected for a release label May 1, 2021

behackl added this to the Release v0.6.0 milestone May 1, 2021

AntonBallmaier suggested changes May 1, 2021

View reviewed changes

abhijithmuthyala reviewed May 1, 2021

View reviewed changes

behackl added 5 commits May 1, 2021 19:40

Merge branch 'master' into prepare-v0.6.0

8f21705

changelog script: fix type of additional PRs

fd71c5e

update autogenerated changelog

75d8b93

add releases category

8a051af

a bit more copyediting

8d83e2b

naveen521kk reviewed May 2, 2021

View reviewed changes

behackl added 2 commits May 2, 2021 12:20

rewrite author logic

9afd5c1

regenerate changelog

a8f1f09

pre-commit-ci bot and others added 2 commits May 2, 2021 10:21

[pre-commit.ci] auto fixes from pre-commit.com hooks

660744b

for more information, see https://pre-commit.ci

Merge remote-tracking branch 'origin/master' into prepare-v0.6.0

bdd9c44

behackl and others added 3 commits May 2, 2021 12:28

regenerate changelog

3d3b503

Merge remote-tracking branch 'origin/master' into prepare-v0.6.0

cdbaf29

Merge branch 'master' into prepare-v0.6.0

5d36daa

huguesdevimeux approved these changes May 2, 2021

View reviewed changes

jsonvillanueva approved these changes May 2, 2021

View reviewed changes

docs/source/changelog/0.6.0-changelog.rst Outdated Show resolved Hide resolved

docs/source/changelog/0.6.0-changelog.rst Outdated Show resolved Hide resolved

kolibril13 approved these changes May 2, 2021

View reviewed changes

behackl and others added 5 commits May 2, 2021 16:51

merge logic for authors/reviewers and label sorting (fewer GH requests!)

9ef8ad5

regenerate changelog

6ee38fe

Merge branch 'prepare-v0.6.0' of github.com:ManimCommunity/manim into…

da98ab1

… prepare-v0.6.0

[pre-commit.ci] auto fixes from pre-commit.com hooks

f467aa9

for more information, see https://pre-commit.ci

fix some formatting and add more references

d53fc83

Co-authored-by: Jason Villanueva <[email protected]>

AntonBallmaier approved these changes May 2, 2021

View reviewed changes

kilacoda-old approved these changes May 2, 2021

View reviewed changes

behackl merged commit e5a6307 into master May 2, 2021

behackl deleted the prepare-v0.6.0 branch May 2, 2021 15:47

	- Added :func:`~.Mobject.become_points`, which transforms the points, positions and submobjects of a Mobject to match that of the other while keeping style unchanged.
	- Added :meth:`~.Mobject.match_points`, which transforms the points, positions and submobjects of a Mobject to match that of the other while keeping style unchanged.

Prepare v0.6.0 #1434

Prepare v0.6.0 #1434

Uh oh!

Conversation

behackl commented May 1, 2021

Changelog

Uh oh!

behackl commented May 1, 2021

Uh oh!

AntonBallmaier May 1, 2021

Choose a reason for hiding this comment

Uh oh!

jsonvillanueva May 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsonvillanueva May 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

abhijithmuthyala May 1, 2021

Choose a reason for hiding this comment

Uh oh!

Darylgolden May 2, 2021

Choose a reason for hiding this comment

Uh oh!

naveen521kk May 2, 2021

Choose a reason for hiding this comment

Uh oh!

behackl May 2, 2021

Choose a reason for hiding this comment

Uh oh!

behackl commented May 1, 2021

Uh oh!

Darylgolden commented May 2, 2021

Uh oh!

jsonvillanueva commented May 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Darylgolden commented May 2, 2021

Uh oh!

jsonvillanueva commented May 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Darylgolden commented May 2, 2021

Uh oh!

Darylgolden commented May 2, 2021

Uh oh!

kolibril13 commented May 2, 2021

Uh oh!

behackl commented May 2, 2021

Uh oh!

kolibril13 commented May 2, 2021

Uh oh!

hydrobeam commented May 2, 2021

Uh oh!

naveen521kk May 2, 2021

Choose a reason for hiding this comment

Uh oh!

Darylgolden commented May 2, 2021

Uh oh!

behackl commented May 2, 2021

Uh oh!

jsonvillanueva left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

behackl commented May 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

jsonvillanueva May 1, 2021 •

edited

Loading

jsonvillanueva May 1, 2021 •

edited

Loading

jsonvillanueva commented May 2, 2021 •

edited

Loading

jsonvillanueva commented May 2, 2021 •

edited

Loading

jsonvillanueva left a comment •

edited

Loading