Skip to content

Conversation

@erik-rt
Copy link
Contributor

@erik-rt erik-rt commented Apr 5, 2021

Closes #1250

Changelog / Overview

  • Removed CairoText class from manim.mobject.text_mobject
  • Removed 'CairoText' from __all__
  • Removed reference to CairoText in docstring

Motivation

CairoText is deprecated and should be removed from the library

Explanation for Changes

Testing Status

tests/test_graphical_units/test_opengl.py failed during testing, though the removal of CairoText should not have influenced this test

Further Comments

Checklist

  • I have read the Contributing Guidelines
  • I have written a descriptive PR title (see top of PR template for examples)
  • I have written a changelog entry for the PR or deem it unnecessary
  • My new functions/classes either have a docstring or are private
  • My new functions/classes have tests added and (optional) examples in the docs
  • My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

  • The PR title is descriptive enough
  • The PR is labeled correctly
  • The changelog entry is completed if necessary
  • Newly added functions/classes either have a docstring or are private
  • Newly added functions/classes have tests added and (optional) examples in the docs
  • Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

@jsonvillanueva jsonvillanueva changed the title removed deprecated CairoText class Removed deprecated CairoText class Apr 5, 2021
@jsonvillanueva jsonvillanueva added the pr:deprecation Deprecation, or removal of deprecated code label Apr 5, 2021
Copy link
Member

@jsonvillanueva jsonvillanueva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I don't think CairoText is mentioned anywhere else in docs either.

Copy link
Member

@naveen521kk naveen521kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm, thanks.

@naveen521kk
Copy link
Member

oh, no that check is failing for no reason. maybe do a dummy commit? (I think it should be fixed then.), I should fix it soon

@erik-rt
Copy link
Contributor Author

erik-rt commented Apr 5, 2021

oh, no that check is failing for no reason. maybe do a dummy commit? (I think it should be fixed then.), I should fix it soon

Hey Naveen, should I try making the dummy commit? You're thinking it'll fix itself then?

@naveen521kk
Copy link
Member

Hey Naveen, should I try making the dummy commit? You're thinking it'll fix itself then?

yes, it should ideally fix itself. I will anyhow squash while merging so that doesn't matter.

@naveen521kk naveen521kk merged commit fdb7ecb into ManimCommunity:master Apr 6, 2021
@erik-rt erik-rt deleted the depreciate_cairotext branch April 6, 2021 12:13
@behackl behackl added this to the Release v0.6.0 milestone Apr 6, 2021
@behackl behackl mentioned this pull request May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:deprecation Deprecation, or removal of deprecated code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing CairoText

5 participants