Clear bolus recommendation on initial edit #2349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestSuccess. Works as expected on 4 iOS versions. Test DetailsUse this version of Loop with v3.8.0 of LoopWorkspace. Test with 4 different operating systems.
Background information about the BolusEntryView screenThe designed behavior of tapping on the bolus line should automatically replace the recommended value with zero. Previous tests showed that while this did happen for v3.6.4, it stopped working for some iOS systems after the update, PR #2341, commit a634e2f, was made to accommodate iOS 26 and to clean up old code that needed to be updated. Loop v3.8.0 worked as designed for iOS 15 and iOS 16. |
marionbarker
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The onTapGesture callback is not called on a TextField. Better to use focus anyways; that works with keyboard focus as well.