-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Bolus view fixes, and updates for iOS26 #2341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I have limited ability to test this. This modification behaves nicely on a test phone SE 3rd gen running iOS 18.6.2 built with both Xcode 16.4 and Xcode 26 beta 6. I tried to build to an simulated iPhone 16 with iOS 26 and I was not successful (for both the released version of Loop and for the version with this modification.) There is an Xcode 26 beta 7 available. I am downloading that in case it make a difference. |
Is this apart of DEV? I can build to my iPhone 16 pro if so and test.
Let me know and I’ll give it a go.
Ben
From: Marion Barker ***@***.***>
Date: Sunday, August 31, 2025 at 5:49 PM
To: LoopKit/Loop ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [LoopKit/Loop] Bolus view fixes, and updates for iOS26 (PR #2341)
[https://avatars.githubusercontent.com/u/19607791?s=20&v=4]marionbarker left a comment (LoopKit/Loop#2341)<#2341 (comment)>
I have limited ability to test this. This modification behaves nicely on a test phone SE 3rd gen built with both Xcode 16.4 and Xcode 26 beta 6.
I tried to build to an simulated iPhone 16 with iOS 26 and I was not successful (for both the released version of Loop and for the version with this modification.) There is an Xcode 26 beta 7 available. I am downloading that in case it make a difference.
—
Reply to this email directly, view it on GitHub<#2341 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACWNLO3G53GSVM3UDOUKKG33QOJ2FAVCNFSM6AAAAACFISDUJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENBQGU3DONBYGE>.
You are receiving this because you are subscribed to this thread.
|
I created a temporary branch at LoopKit/LoopWorkspace for folks who use browser build. Then build and choose |
Got it, I don’t use browser build. Just cloned your tmp to a folder and built from there.
Looks like the patch fixes the UI correctly to me. Attached before and after for you.
iPhone 16 pro
iOS 26 beta 5 (public)
iOS 26.0 (23A5330a)
Ben
…________________________________
From: Marion Barker ***@***.***>
Sent: Sunday, August 31, 2025 6:41:55 PM
To: LoopKit/Loop ***@***.***>
Cc: blameitonben ***@***.***>; Mention ***@***.***>
Subject: Re: [LoopKit/Loop] Bolus view fixes, and updates for iOS26 (PR #2341)
[https://avatars.githubusercontent.com/u/19607791?s=20&v=4]marionbarker left a comment (LoopKit/Loop#2341)<#2341 (comment)>
@blameitonben<https://github.com/blameitonben>
I created a temporary branch at LoopKit/LoopWorkspace for folks who use browser build.
You will need to add tmp/dev_plus_loop_pr2341 to your fork.
* see: https://loopkit.github.io/loopdocs/browser/build-dev-browser/#add-branch
Then build and choose tmp/dev_plus_loop_pr2341 as the branch to build.
—
Reply to this email directly, view it on GitHub<#2341 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACWNLO6MPPKZO4YJBDVFA6D3QOP6HAVCNFSM6AAAAACFISDUJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENBQGYZTCOJXGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Attaching images via email doesn’t work. You need to go to the web browser to upload the images. |
|
@blameitonben would you also check external insulin addition with the new build. There’s a report on zulipchat that it still fails https://loop.zulipchat.com/#narrow/channel/144182-development/topic/iOS.2026.20bug/near/537043655 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm adding my approval because this fixes the pump manual bolus issue.
It does not fix the external insulin issue (still missing the "Log Dose" button).
If that fix makes it in before I merge this PR, that's great. Otherwise, I will go with this partial fix of the most important feature for iOS 26.
That report is correct, I’m not seeing a log dose button when trying to manually log physical insulin doses.
Feel free to let me know if an update is pushed and I can rebuild for testing and let you know the results there.
If you need a screen shot I can pop back in and upload it.
Ben
From: Marion Barker ***@***.***>
Date: Monday, September 1, 2025 at 8:01 AM
To: LoopKit/Loop ***@***.***>
Cc: blameitonben ***@***.***>, Mention ***@***.***>
Subject: Re: [LoopKit/Loop] Bolus view fixes, and updates for iOS26 (PR #2341)
[https://avatars.githubusercontent.com/u/19607791?s=20&v=4]marionbarker left a comment (LoopKit/Loop#2341)<#2341 (comment)>
@blameitonben<https://github.com/blameitonben> would you also check external insulin addition with the new build. There’s a report on zulipchat that it still fails but I have a PM from someone that it worked for them.
https://loop.zulipchat.com/#narrow/channel/144182-development/topic/iOS.2026.20bug/near/537043655
—
Reply to this email directly, view it on GitHub<#2341 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACWNLOZNUTKFW4LVOSVP4TT3QRNUZAVCNFSM6AAAAACFISDUJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENBSGY3TCNJUGE>.
You are receiving this because you were mentioned.
|
Code review of most recent commit looks good. I updated the temporary LoopWorkspace branch: If we can get an actual phone test on the updated version, I will merge this PR and add the fix to dev branch. |
I can confirm the latest change fixes the 2nd issue for “Log Dose” when manually entering insulin into loop. I tested also automated delivery via add carbs, and found everything worked as expected also with no regression there.
I’ve taken screen shots if you want them uploaded to the thread let me know so I can pop them in there.
Ben
From: Marion Barker ***@***.***>
Date: Monday, September 1, 2025 at 12:47 PM
To: LoopKit/Loop ***@***.***>
Cc: blameitonben ***@***.***>, Mention ***@***.***>
Subject: Re: [LoopKit/Loop] Bolus view fixes, and updates for iOS26 (PR #2341)
[https://avatars.githubusercontent.com/u/19607791?s=20&v=4]marionbarker left a comment (LoopKit/Loop#2341)<#2341 (comment)>
Code review of most recent commit looks good.
I updated the temporary LoopWorkspace branch:
* https://github.com/LoopKit/LoopWorkspace/tree/tmp/dev_plus_loop_pr2341
If we can get an actual phone test on the updated version, I will merge this PR and add the fix to dev branch.
—
Reply to this email directly, view it on GitHub<#2341 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACWNLO57ZQNM3XNDSYB4LPT3QSPDVAVCNFSM6AAAAACFISDUJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENBTGE3DIOBQGI>.
You are receiving this because you were mentioned.
|
I got a report in [zulipchat](#development > iOS 26 bug @ 💬) that this fixes the external insulin UI issue. |
Should fix #2335