Skip to content

Conversation

ps2
Copy link
Collaborator

@ps2 ps2 commented Aug 31, 2025

Should fix #2335

@marionbarker
Copy link
Contributor

marionbarker commented Sep 1, 2025

I have limited ability to test this. This modification behaves nicely on a test phone SE 3rd gen running iOS 18.6.2 built with both Xcode 16.4 and Xcode 26 beta 6.

I tried to build to an simulated iPhone 16 with iOS 26 and I was not successful (for both the released version of Loop and for the version with this modification.) There is an Xcode 26 beta 7 available. I am downloading that in case it make a difference.

@blameitonben
Copy link

blameitonben commented Sep 1, 2025 via email

@marionbarker
Copy link
Contributor

@blameitonben

I created a temporary branch at LoopKit/LoopWorkspace for folks who use browser build.
You will need to add tmp/dev_plus_loop_pr2341 to your fork.

Then build and choose tmp/dev_plus_loop_pr2341 as the branch to build.

@blameitonben
Copy link

blameitonben commented Sep 1, 2025 via email

@marionbarker
Copy link
Contributor

@blameitonben

Attaching images via email doesn’t work. You need to go to the web browser to upload the images.

@blameitonben
Copy link

@blameitonben

Attaching images via email doesn’t work. You need to go to the web browser to upload the images.

Sorry I forgot about that! Here you go.
IMG_3120
IMG_3121

@marionbarker
Copy link
Contributor

marionbarker commented Sep 1, 2025

@blameitonben would you also check external insulin addition with the new build. There’s a report on zulipchat that it still fails but I have a PM from someone that it worked for them. Edited because now the user (from the PM) reports that with iOS26 beta 8, the external insulin is failing as reported by the zulipchat user, but the pump bolus is working still.

https://loop.zulipchat.com/#narrow/channel/144182-development/topic/iOS.2026.20bug/near/537043655

Copy link
Contributor

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding my approval because this fixes the pump manual bolus issue.

It does not fix the external insulin issue (still missing the "Log Dose" button).

If that fix makes it in before I merge this PR, that's great. Otherwise, I will go with this partial fix of the most important feature for iOS 26.

@blameitonben
Copy link

blameitonben commented Sep 1, 2025 via email

@marionbarker
Copy link
Contributor

Code review of most recent commit looks good.

I updated the temporary LoopWorkspace branch:

If we can get an actual phone test on the updated version, I will merge this PR and add the fix to dev branch.

@blameitonben
Copy link

blameitonben commented Sep 1, 2025 via email

@marionbarker
Copy link
Contributor

I got a report in [zulipchat](#development > iOS 26 bug @ 💬) that this fixes the external insulin UI issue.
Merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot bolus in iOS 26 public beta 4

3 participants