Conversions for scala collections (continued) #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….0, fixed aligning and added explicit types to all calls (prevents complaining by some scala functions)
…enamed conversions to kotlin to include "asKotlin" (can be discussed)
…enamed conversions to kotlin to include "asKotlin" (can be discussed)
…verters back to JavaConversions
Contributor
|
Awesome contribution, thank you! Is it finished? |
Contributor
|
BTW it looks like it could be moved to the |
Collaborator
Author
For me, moving it into the common module didn't work, since that module doesn't have access to the Scala library with the conversions. You can try it yourself if you like, because it would definitely be better. |
Contributor
|
Oh, agreed! Could you please fix conflicts than for me to be able to merge the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the work from #72 and provides easy to use wrappers for Kotlin to convert between Scala and Kotlin collections.
I noticed that the conversions cannot be put in the
commonfolder due to the Scala conversion functions being absent there, so I added the conversions to both 2.4 and 3.0 including some tests.I also changed the naming, which can be discussed, to be more consistent:
and