Add Extensions for creating the Scala-Java-Wrapper #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Shouldn't it be implemented inside |
Contributor
|
Also, I don't really think functions should be inline. |
Collaborator
|
I think this can be closed now, since the functionality is merged :) |
Contributor
Author
Wonderful, sorry that i forgot to work on it. But at the moment i can't find the time for any "bigger" hobby programming project. ^^' |
Contributor
|
Thank y'all for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Everyone,
it is just a simple Weapper for the JavaConversions Class.
It needs some unittests and a port to v3.0, i'll work on it around christmas.
In the meantime i would be glad if you could give me some feedback what it needs and how you would test these conversions.