Update @snoop_inference for Julia 1.12
#419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Apr 15, 2025
vtjnash
reviewed
Apr 15, 2025
timholy
force-pushed
the
teh/new_inftiming
branch
2 times, most recently
from
3622e17 to
49ff0b2
Compare
Member
Author
|
Passes locally except the JET extension test ( |
This was referenced Jul 25, 2025
timholy
force-pushed
the
teh/new_inftiming
branch
from
df20e25 to
3262f50
Compare
Get some stuff working Add backtraces to itrigs This depends on changes to Julia More tests working Improve handling of constprop more tree work flamegraphs Apply suggestions from code review Co-authored-by: Jameson Nash <[email protected]> Various fixes More fix
timholy
force-pushed
the
teh/new_inftiming
branch
from
d2d2b5c to
7008f58
Compare
These turned out to be an artifact of coverage discarding CodeInstances.
Member
Author
|
The main tests pass, it's now the Cthulhu extension that fails. |
timholy
added a commit
that referenced
this pull request
Sep 3, 2025
This leverages the new timing fields of CodeInstance to replace the old Core.Compiler.Timings module. There is a bit of loss particularly in the domain of constant-propagation, which is illustrated in https://gist.github.com/timholy/9a64b27c1932bb414e69b8fe48284b5e. (Read testcase.jl before looking at the results.) As a consequence there are a small handful of failing tests locally, but the vast majority pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leverages the new timing fields of
CodeInstanceto replace the oldCore.Compiler.Timingsmodule. There is a bit of loss particularly in the domain of constant-propagation, which is illustrated in https://gist.github.com/timholy/9a64b27c1932bb414e69b8fe48284b5e. (Readtestcase.jlbefore looking at the results.) As a consequence there are a small handful of failing tests locally, but the vast majority pass.This requires JuliaLang/julia#58124 or alternatively (with some modification to this PR) JuliaLang/julia#58123.