Apply suggestions from code review

Co-authored-by: Jameson Nash <[email protected]>

Author: timholy

SnoopCompileCore/src/snoop_inference.jl

@@ -4,7 +4,7 @@ const snoop_inference_lock = ReentrantLock()
 const newly_inferred = CodeInstance[]
 
 function start_tracking()
-    islocked(snoop_inference_lock) && error("already tracking inference (cannot nest `@snoop_inference` blocks)")
+    snoop_inference_lock.reentrancy_cnt == 1 || throw(ConcurrencyViolationError("already tracking inference (cannot nest `@snoop_inference` blocks)"))
     lock(snoop_inference_lock)
     empty!(newly_inferred)
     ccall(:jl_set_newly_inferred, Cvoid, (Any,), newly_inferred)
@@ -15,7 +15,7 @@ function start_tracking()
 end
 
 function stop_tracking()
-    @assert islocked(snoop_inference_lock)
+    Base.assert_havelock(snoop_inference_lock)
     ccall(:jl_set_newly_inferred, Cvoid, (Any,), nothing)
     unlock(snoop_inference_lock)
     # ccall(:jl_log_dispatch_backtrace, Any, (Cint,), 0)